Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkbox - Fix Checked and Indeterminate States & Remove FormLabelInline #459

Closed
2 of 4 tasks
Tracked by #452
thrbnhrtmnn opened this issue Oct 18, 2023 · 3 comments
Closed
2 of 4 tasks
Tracked by #452
Labels
⌨️ dev issue Task is for developers

Comments

@thrbnhrtmnn
Copy link
Contributor

thrbnhrtmnn commented Oct 18, 2023

Description / Bug

1. Fix Checked Style
Current behavior:
The checkbox component has indeterminate attribute that could be added to and removed from the input element (to reproduce, toggle the corresponding properties in the props panel in Storybook). The checked style is only being applied on click, and this is not adding

Expected behavior:
By adding and removing this property, the style of checked checkbox should be applied / removed.
On checkbox click, the property should be applied / removed from the input element.

2. Fix Indeterminate Style
Current behavior:
Indeterminate style is not being applied at all.

Expected behavior:
Indeterminate style is applied when indeterminate property is added to the input element.

3. Fix Checkbox Label
Current behavior:
Checkbox is using an internal component called FormLabelInline.

Expected behavior:
Checkbox should not use an internal component for the label, it should use an element that is a part of checkbox.
The FormLabelInline component should be deleted.


Acceptance Criteria

  • Checked styles should be applied when the checked property is added to the input element (or toggled in Storybook)
  • Indeterminate styles should be applied when the indeterminate property is added to the input element (or toggled in Storybook)
  • Checkbox component should not use internal label inline component but another (label) element
  • FormLabelInline is removed from the code

Background information

None

@thrbnhrtmnn thrbnhrtmnn added this to the Release 1.0 milestone Oct 18, 2023
@angelicahoyss angelicahoyss changed the title FormLabel - merge component instances in code Checkbox - Fix Checked and Indeterminate States & Remove FormLabelInline Oct 20, 2023
@angelicahoyss
Copy link
Contributor

@thrbnhrtmnn Completed the description of the checkbox bug we discussed last week

@thrbnhrtmnn
Copy link
Contributor Author

Hey @ChristianHoffmannS2 , could you quickly verify that this is already done? All things I could verify visually I already checked :-)

@thrbnhrtmnn
Copy link
Contributor Author

As discussed in the design review: Lets close this issue and make a new one to think about FormLabelInline and then after making a decision, adjust all affected components. Maybe we will introduce a standalone label component or an unstyled label component we have to discuss.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⌨️ dev issue Task is for developers
Projects
None yet
Development

No branches or pull requests

2 participants