You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
1. Fix Checked Style
Current behavior:
The checkbox component has indeterminate attribute that could be added to and removed from the input element (to reproduce, toggle the corresponding properties in the props panel in Storybook). The checked style is only being applied on click, and this is not adding
Expected behavior:
By adding and removing this property, the style of checked checkbox should be applied / removed.
On checkbox click, the property should be applied / removed from the input element.
2. Fix Indeterminate Style
Current behavior:
Indeterminate style is not being applied at all.
Expected behavior:
Indeterminate style is applied when indeterminate property is added to the input element.
3. Fix Checkbox Label
Current behavior:
Checkbox is using an internal component called FormLabelInline.
Expected behavior:
Checkbox should not use an internal component for the label, it should use an element that is a part of checkbox.
The FormLabelInline component should be deleted.
Acceptance Criteria
Checked styles should be applied when the checked property is added to the input element (or toggled in Storybook)
Indeterminate styles should be applied when the indeterminate property is added to the input element (or toggled in Storybook)
Checkbox component should not use internal label inline component but another (label) element
FormLabelInline is removed from the code
Background information
None
The text was updated successfully, but these errors were encountered:
angelicahoyss
changed the title
FormLabel - merge component instances in code
Checkbox - Fix Checked and Indeterminate States & Remove FormLabelInline
Oct 20, 2023
As discussed in the design review: Lets close this issue and make a new one to think about FormLabelInline and then after making a decision, adjust all affected components. Maybe we will introduce a standalone label component or an unstyled label component we have to discuss.
Description / Bug
1. Fix Checked Style
Current behavior:
The checkbox component has indeterminate attribute that could be added to and removed from the input element (to reproduce, toggle the corresponding properties in the props panel in Storybook). The checked style is only being applied on click, and this is not adding
Expected behavior:
By adding and removing this property, the style of checked checkbox should be applied / removed.
On checkbox click, the property should be applied / removed from the input element.
2. Fix Indeterminate Style
Current behavior:
Indeterminate style is not being applied at all.
Expected behavior:
Indeterminate style is applied when indeterminate property is added to the input element.
3. Fix Checkbox Label
Current behavior:
Checkbox is using an internal component called FormLabelInline.
Expected behavior:
Checkbox should not use an internal component for the label, it should use an element that is a part of checkbox.
The FormLabelInline component should be deleted.
Acceptance Criteria
Checkbox component should not use internal label inline component but another (label) elementFormLabelInline is removed from the codeBackground information
None
The text was updated successfully, but these errors were encountered: