Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RadioGroup - make legend optional #388

Closed
8 tasks done
Tracked by #452
larserbach opened this issue Sep 27, 2023 · 6 comments
Closed
8 tasks done
Tracked by #452

RadioGroup - make legend optional #388

larserbach opened this issue Sep 27, 2023 · 6 comments
Assignees
Labels
🎨 design issue Task is for designers ⌨️ dev issue Task is for developers 🎓 junior issue Good for juniors 🚨 new::bug Something isn't working

Comments

@larserbach
Copy link
Contributor

larserbach commented Sep 27, 2023

In Figma the legend isn't optional yet. The developed component already has an optional legend.
The current layout must be changed, because if the legend is hidden, there remains an undesired top padding on the RadioStack.

Image

Design tasks:

  • make the visibility of the legend a boolean prop
  • remove token from Radio Stack, or set to zero paddingTop: "Forms.RadioGroup.SM.RadioStack.PaddingTop";
  • add wrapper for legend
  • add bottom padding for legend wrapper
  • document changes on this ticket

Dev tasks:

  • create wrapper for legend
  • apply tokens provided by des
  • remove token if applicable
@larserbach larserbach added the 🚨 new::bug Something isn't working label Sep 27, 2023
@thrbnhrtmnn thrbnhrtmnn added this to the Release 1.0 milestone Sep 29, 2023
@thrbnhrtmnn thrbnhrtmnn added the 🎓 junior issue Good for juniors label Oct 4, 2023
@kaikdi kaikdi self-assigned this Oct 5, 2023
@DenizSaganak
Copy link
Contributor

DenizSaganak commented Oct 6, 2023

Continuing with the ticket Radio Group - add global caption/hint improvements #402

@larserbach
Copy link
Contributor Author

Design is done
Branch
PR

@DenizSaganak
Copy link
Contributor

Dev is done
PR: #453

@thrbnhrtmnn
Copy link
Contributor

We looked at the component and the padding was moved to the legend in the code, but we could not verify if everything is done, as design is not updated yet.

@DenizSaganak
Copy link
Contributor

Dev is done
PR: #591

@thrbnhrtmnn
Copy link
Contributor

After merge this task can be closed as done. But we will wait for the tokens & git ignore topic to be resolved before doing it.

@thrbnhrtmnn thrbnhrtmnn added 🎨 design issue Task is for designers ⌨️ dev issue Task is for developers labels Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 design issue Task is for designers ⌨️ dev issue Task is for developers 🎓 junior issue Good for juniors 🚨 new::bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants