Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ButtonGroup - use slots to have IconButtons and TextButtons in the ButtonGroup #387

Closed
2 tasks done
Tracked by #452 ...
thrbnhrtmnn opened this issue Sep 26, 2023 · 5 comments
Closed
2 tasks done
Tracked by #452 ...
Assignees
Labels
⌨️ dev issue Task is for developers

Comments

@thrbnhrtmnn
Copy link
Contributor

thrbnhrtmnn commented Sep 26, 2023

Description

From the Merge- and Review-Session on 26.09. a few open/additional topics for the #246 came up that are followed up in this task.

After discussing this task in the refinement on 26.10. we decided to use slots to integrate the IconButton and TextButton component into the Button Group. Right now, the Button Group is not using these components but has Buttons that are just styled like a text button.


Acceptance Criteria

  • The Button Group can contain Icon Buttons and Text Buttons inside slots, as well as both at the same time.
  • Props documentation has been updated in Storybook and in Props Excel (on the All Props page and on the Components page)

Background information

  • look at the figma design to see what combination examples of icon button and text button can exist
@thrbnhrtmnn thrbnhrtmnn added the 🎓 junior issue Good for juniors label Oct 4, 2023
@thrbnhrtmnn thrbnhrtmnn added this to the Release 1.0 milestone Oct 13, 2023
@thrbnhrtmnn thrbnhrtmnn changed the title Button Group - add option to also have icon buttons in the group ButtonGroup - add option to also have icon buttons in the group Oct 17, 2023
@thrbnhrtmnn
Copy link
Contributor Author

As discussed in the refinement today, we have some scope change:

  • In order to add an iconButton, we need to figure out how to add slots/children
  • The buttons in the buttonGroup should be instances of the existing TextButton or IconButton components

@RubirajAccenture
Copy link
Contributor

The tech concept of passing the children must be discussed with the technical team. Kindly contact @ChristianHoffmannS2 before picking up the ticket

@RubirajAccenture RubirajAccenture added 🦹 needs:contact Needs information by a missing contact 🦹 needs:help Extra attention is needed and removed 🎓 junior issue Good for juniors labels Oct 26, 2023
@thrbnhrtmnn thrbnhrtmnn changed the title ButtonGroup - add option to also have icon buttons in the group ButtonGroup - use slots to either have IconButtons or TextButtons in the ButtonGroup Oct 27, 2023
@thrbnhrtmnn thrbnhrtmnn changed the title ButtonGroup - use slots to either have IconButtons or TextButtons in the ButtonGroup ButtonGroup - use slots to have IconButtons and TextButtons in the ButtonGroup Oct 27, 2023
@thrbnhrtmnn thrbnhrtmnn removed 🦹 needs:contact Needs information by a missing contact 🦹 needs:help Extra attention is needed labels Oct 27, 2023
@thrbnhrtmnn
Copy link
Contributor Author

Hey @ChristianHoffmannS2 , Hey @RubirajAccenture ,

I had a look at the new button group today and already checked both ACs. Before closing the ticket, I have some questions though:

  • Is it possible to also change the size for all the buttons in the group? Currently when switching the size, only the item-spacing changes
  • Does the ButtonGroup also need events? I guess not, since the Text and the Icon Button both have the events.

@ChristianHoffmannS2
Copy link
Collaborator

the button group does not need events. if we want a global submit event for instance, we properly will do that with a "formgroup" thingy.

inheriting things like theme or size would be great, but needs investigation. i am not sure yet how, but would love to see that as well

@thrbnhrtmnn
Copy link
Contributor Author

thrbnhrtmnn commented Nov 15, 2023

Okay, I will create a follow up task to investigate this. But this task I will close as this investigation is not part of the scope.

Link to the follow up issue: #593

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⌨️ dev issue Task is for developers
Projects
None yet
Development

No branches or pull requests

3 participants