-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ButtonGroup - use slots to have IconButtons and TextButtons in the ButtonGroup #387
Comments
As discussed in the refinement today, we have some scope change:
|
The tech concept of passing the children must be discussed with the technical team. Kindly contact @ChristianHoffmannS2 before picking up the ticket |
Hey @ChristianHoffmannS2 , Hey @RubirajAccenture , I had a look at the new button group today and already checked both ACs. Before closing the ticket, I have some questions though:
|
the button group does not need events. if we want a global submit event for instance, we properly will do that with a "formgroup" thingy. inheriting things like theme or size would be great, but needs investigation. i am not sure yet how, but would love to see that as well |
Okay, I will create a follow up task to investigate this. But this task I will close as this investigation is not part of the scope. Link to the follow up issue: #593 |
Description
From the Merge- and Review-Session on 26.09. a few open/additional topics for the #246 came up that are followed up in this task.
After discussing this task in the refinement on 26.10. we decided to use slots to integrate the IconButton and TextButton component into the Button Group. Right now, the Button Group is not using these components but has Buttons that are just styled like a text button.
Acceptance Criteria
Background information
The text was updated successfully, but these errors were encountered: