Resolved: feat(ui-library): bug fix in slider #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pheolink
force-pushed
the
feat-range-slider
branch
from
6ec7e02 to
5ade2bc
Compare
pheolink
changed the title
pheolink
force-pushed
the
feat-range-slider
branch
2 times, most recently
from
e436ab8 to
1f9b256
Compare
davidken91
reviewed
Sep 5, 2023
| export const findToolTipPosition = (minVal: string, maxVal: string, offsetWidthVal: number, value: number) => { | ||
| const min = parseFloat(minVal); | ||
| const max = parseFloat(maxVal); | ||
| const width = offsetWidthVal; |
There was a problem hiding this comment.
For some reason, when we get the width of the range slider, the dimensions that we get are bigger than what actually appears on screen. I initially thought this was to do with margin and padding on the sides, but we don't apply either of those styles. I think if we can get the correct width of the input element, then the tooltip will be placed more accurately
pheolink
force-pushed
the
feat-range-slider
branch
2 times, most recently
from
a1a7c15 to
a159572
Compare
4 tasks
pheolink
force-pushed
the
feat-range-slider
branch
2 times, most recently
from
a1770f4 to
a4d7a5f
Compare
pheolink
force-pushed
the
feat-range-slider
branch
from
a4d7a5f to
15e6fc1
Compare
This was referenced Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.