Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(icons): adds error and error-filled icon #204

Merged
merged 1 commit into from
Jun 5, 2023
Merged

feat(icons): adds error and error-filled icon #204

merged 1 commit into from
Jun 5, 2023

Conversation

orivaa
Copy link
Contributor

@orivaa orivaa commented Jun 3, 2023

  • put new svgs in packages/icons/icon-set
  • run npm run compile:icons in project root
  • git add .
  • git commit -m "feat(icons): adds new icons"
    done

@orivaa orivaa linked an issue Jun 3, 2023 that may be closed by this pull request
Icon - add missing icons (i.e. error-filled) #202
Closed
@ChristianHoffmannS2 ChristianHoffmannS2 self-requested a review June 5, 2023 11:57
@ChristianHoffmannS2 ChristianHoffmannS2 merged commit 146ec29 into develop Jun 5, 2023
@ChristianHoffmannS2 ChristianHoffmannS2 deleted the feat/error-icon branch June 5, 2023 12:06
This was referenced Jan 6, 2025
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristianHoffmannS2 ChristianHoffmannS2 ChristianHoffmannS2 approved these changes

@davidken91 davidken91 davidken91 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Icon - add missing icons (i.e. error-filled)
3 participants
@orivaa @ChristianHoffmannS2 @davidken91