Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text Area, Input Field Text, Input Field Number, Select - remove pressed state & update focus state #1155

Open
1 of 21 tasks
thrbnhrtmnn opened this issue Sep 9, 2024 · 0 comments · May be fixed by #1172
Open
1 of 21 tasks
Assignees
Labels
⭕ core team issue This is for the core team and should not be done by contributors 🎨 design issue Task is for designers ⌨️ dev issue Task is for developers

Comments

@thrbnhrtmnn
Copy link
Contributor

thrbnhrtmnn commented Sep 9, 2024

Description / User story

As researched and proposed in #1125 the pressed state should be removed for the Text Area, Input Field Text, Input Field Number and Select components, as it is not used for input fields.

Further more the focus state should be updated so it only contains the needed tokens for storke-color, stroke-width and potentially background-color. In code the focus state should also always dominate other states and overwrite all other tokens.

Requirements / Prerequisites

  • none

Acceptance Criteria

  • The pressed state has been removed in design from:

    • Text Area
    • Input Field Text
    • Input Filed Number
    • Select
  • The pressed state has been removed in code from:

    • Text Area
    • Input Field Text
    • Input Filed Number
    • Select
  • The focus state of the following components in code uses all tokens as defined in design:

    • Text Area
    • Input Field Text
    • Input Filed Number
    • Select
  • The focus states dominates other states like hover or readonly for the following components in code:

    • Text Area
    • Input Field Text
    • Input Filed Number
    • Select

Additional information

  • ...

Code of Conduct

  • I agree to follow this project's Code of Conduct
@thrbnhrtmnn thrbnhrtmnn added 🎨 design issue Task is for designers ⌨️ dev issue Task is for developers ⭕ core team issue This is for the core team and should not be done by contributors labels Sep 9, 2024
@ashk1996 ashk1996 self-assigned this Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⭕ core team issue This is for the core team and should not be done by contributors 🎨 design issue Task is for designers ⌨️ dev issue Task is for developers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants