Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkbox - multiple behaviour fixes in code #1157

Open
1 of 6 tasks
Tracked by #452
thrbnhrtmnn opened this issue Sep 11, 2024 · 0 comments
Open
1 of 6 tasks
Tracked by #452

Checkbox - multiple behaviour fixes in code #1157

thrbnhrtmnn opened this issue Sep 11, 2024 · 0 comments
Labels
⭕ core team issue This is for the core team and should not be done by contributors ⌨️ dev issue Task is for developers

Comments

@thrbnhrtmnn
Copy link
Contributor

thrbnhrtmnn commented Sep 11, 2024

Description / User story

The checkbox currently seems to have some issues where it is not behaving as intended:

  • Currently, when indeterminate icon gets clicked it gets checked. I believe this is wrong and the value should not change. This is how it is behaving in mdn web docs.
  • When hasError=true, the component seems to have an empty blr-form-caption-group container. This should not be there unless errorMessage or errorMessageIcon also have a value. Compare this to radio, where this works as intended.
  • When hasHint=true, but hintMessage and hintMessageIcon are empty, the component seems to have an empty blr-form-caption-group container. This should not be there. Compare this to radio, where this works as intended.
  • The checkbox currently switches to checked/unchecked, when the mouse button is pressed down. I believe the checking/unchecking should only happen once the mouse button is released, while the cursor is still within the control. This is how it behaves in mdn web docs.
  • When hasError=true, switching indeterminatedt to true does not show the indeterminated icon as defined in design. This needs to be fixed in code.

Requirements / Prerequisites

  • none

Acceptance Criteria

  • Clicking on the indeterminate checkbox does not change the value
  • When hasError=true, but errorMessage and errorMessageIcon are empty/undefined there the caption container does not contain an empty blr-form-caption-group
  • When hasHint=true, but hintMessage and hintMessageIcon are empty/undefined there the caption container does not contain an empty blr-form-caption-group
  • When clicking the checkbox control, the switch from unchecked to checked and vice-versa happens once the pressed down mouse button gets released while the cursor is within the control
  • When hasError=true and indeterminated=true, the checkbox shows the indeterminated checkbox in the error state.

Additional information

  • ...

Code of Conduct

  • I agree to follow this project's Code of Conduct
@thrbnhrtmnn thrbnhrtmnn added ⌨️ dev issue Task is for developers ⭕ core team issue This is for the core team and should not be done by contributors labels Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⭕ core team issue This is for the core team and should not be done by contributors ⌨️ dev issue Task is for developers
Projects
None yet
Development

No branches or pull requests

1 participant