Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select - remove slot and pass options as an array #1128

Closed
2 tasks done
Tracked by #452
thrbnhrtmnn opened this issue Jun 20, 2024 · 0 comments · Fixed by #1131
Closed
2 tasks done
Tracked by #452

Select - remove slot and pass options as an array #1128

thrbnhrtmnn opened this issue Jun 20, 2024 · 0 comments · Fixed by #1131
Assignees
Labels
⭕ core team issue This is for the core team and should not be done by contributors ⌨️ dev issue Task is for developers

Comments

@thrbnhrtmnn
Copy link
Contributor

thrbnhrtmnn commented Jun 20, 2024

Description / User story

The native Select element must have an option element as it's children. The original idea to use slot as a placeholder in the Select component and later on while using the Select component pass the options element from outside as the slotted elements does not work as expected. For a time being until the custom Select element gets created, it was decided to pass the options as an array.

Acceptance Criteria

  • Select component should work when the options is passed as an array.

Additional information

  • In the future the plan is to create an custom Select component which then allows to pass the option element as slotted elements.

Code of Conduct

  • I agree to follow this project's Code of Conduct
@thrbnhrtmnn thrbnhrtmnn added ⌨️ dev issue Task is for developers ⭕ core team issue This is for the core team and should not be done by contributors labels Jun 20, 2024
@angsherpa456 angsherpa456 changed the title Select - update approach to add the options for the native select Select - remove slot and pass options as an array Jun 20, 2024
@angsherpa456 angsherpa456 self-assigned this Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⭕ core team issue This is for the core team and should not be done by contributors ⌨️ dev issue Task is for developers
Projects
None yet
2 participants