Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input Field Number - manual accessibility testing #1020

Open
1 of 5 tasks
thrbnhrtmnn opened this issue Mar 14, 2024 · 0 comments
Open
1 of 5 tasks

Input Field Number - manual accessibility testing #1020

thrbnhrtmnn opened this issue Mar 14, 2024 · 0 comments
Labels
⭕ core team issue This is for the core team and should not be done by contributors ⌨️ dev issue Task is for developers 📋 task::ready Task is ready to be picked up or planned in

Comments

@thrbnhrtmnn
Copy link
Contributor

thrbnhrtmnn commented Mar 14, 2024

Description / User story

The idea of this issue is to compare our coded Input Field Number component with similar components from at least 2 other component libraries in terms of accessibility.

We should closely inspect the accessibility tree, find differences and evaluate which approach we think is the best. If this means we need to adjust our component we should do so.

As this is the first such task that we have, the outcome should be presented to the dev team to enable them to also start with similar tasks looking at our other components.

This task could be done best in pairs.

We initially had the same idea within issue #376, but we decided to split this up as it was too big of a task.

Requirements / Prerequisites

  • none

Acceptance Criteria

  • Input Field Number accessibility tree has been compared with other number input components
  • Differences have been evaluated
  • Input Field Number has been updated in case we think other approaches are better than ours
  • Outcome has been presented to the whole dev team

Additional information

Links

One thing we should probably also change is that aria labels should not be props in our components. Also see recommendation here and the discussion above.

Code of Conduct

  • I agree to follow this project's Code of Conduct
@thrbnhrtmnn thrbnhrtmnn added ⌨️ dev issue Task is for developers ⭕ core team issue This is for the core team and should not be done by contributors 📋 task::ready Task is ready to be picked up or planned in labels Mar 14, 2024
@thrbnhrtmnn thrbnhrtmnn added this to the Accessibiltiy Testing milestone Mar 15, 2024
@thrbnhrtmnn thrbnhrtmnn changed the title Number Input - manual accessibility testing Input Field Number - manual accessibility testing Mar 26, 2024
@davidken91 davidken91 self-assigned this Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⭕ core team issue This is for the core team and should not be done by contributors ⌨️ dev issue Task is for developers 📋 task::ready Task is ready to be picked up or planned in
Projects
None yet
Development

No branches or pull requests

2 participants