fix(ui-library): fix icon button events #1018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added lit-analyzer to compile step and updated vs code extensions * updated lit and added github worklflow * updated path * pathes stuff * github jobs renaming * ignore analyze in the pipeline * test the attribute * removed comment * dont update lit * dont update lit
…lder text (#719) * fix the numberinput to always display stepper before, stepper would disappear if you set the unit to undefined or readonly to true. this was because of conditonal rendering conditions. this fixes the problem by extracting the stepper render function outside the rendering condition of unit inside the input. * display the placeholder for default value the default value in not undefined, so it would hinder and unable the placeholder to be visible. this adds a condition to render the placeholder if it's not the default value * adds test for disappearing stepper buttons --------- Co-authored-by: Muhammad Usman <bcs.12.16@gmail.com> Co-authored-by: Christian Hoffmann <112889877+ChristianHoffmannS2@users.noreply.github.com>
…loading to icons and run test against build (#718) * commit before passing * got icons chunked * fix eslint issue
- deleting old contribute file, so a new one that is linked in the About section of the repo can be added Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>
Adding a new contribute file, which will also be displayed under about on the repo starting page Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>
Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>
fixed links to: - contribution.md - code of conduct md - discussion board Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>
Removing the duplicate contribution.md file, as the correct file now is located outside of the doc folder. This change was done, to comply with the the GitHub Community Standards. Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>
- Updated year in license.md to 2023-2024 - Also fixed an error, where B01LER was not replacing the full placeholder Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>
Updated the labels under Tipps to find issues, and added the "core team issue" label, which was newly introduced. Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>
Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>
* feat(storybook): added Counter Stories --------- Co-authored-by: Christian Hoffmann <112889877+ChristianHoffmannS2@users.noreply.github.com> Co-authored-by: David Kennedy <david.a.kennedy@accenture.com>
* fix(tokens): moves and renames label tokens are renamed to component name and moved into component sets * feat: adds FormLabel to style-dictionary.config * fix: apply renamed tokens to forms.css * feat(tokens) moving label colors to CMP forms.label.[state] stays in SEM but will not be applied onto component anymore * fix: replaces Forms.Label with Forms.FormLabel Also fixes LabelNextToControl colors in multiple files. * fix(tokens): move nextToConrol from SEM to CMP also renames to InlineLabel * fix: fix occurances of labelNextToControl This typotoken moved to CMP and was renamed to ..LabelInline.Typography. * moved checkbox css changes to component css file and deleted global * removed comma * readded correct tokens to checkbox * fixed radio css file --------- Co-authored-by: larserbach <larserbach@users.noreply.github.com>
* fix(tokens): renames textarea minHeight * fix: apply new tokennames at Textarea css --------- Co-authored-by: larserbach <larserbach@users.noreply.github.com>
* feat(storybook): added form Label Story * fix(storybook): added line break * fix(storybook): changed some little text and stories after review * fix(storybook): fixed some text changes after review --------- Co-authored-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>
* fix(storybook): added some changes after review * fix(storybook): added changes after review --------- Co-authored-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>
* we need a relative path here * fix for range slider only * fixed some imports and deactivated icon tests * now all tests run against build * prod fix of example app
* added dependencies to story for buttons * fix for all
* icon uses correct event handling for blrClick - fixes password * compile issues
* feat: updates ItemSpacings to have different values per size * remove configuration --------- Co-authored-by: larserbach <larserbach@users.noreply.github.com> Co-authored-by: Christian Hoffmann <112889877+ChristianHoffmannS2@users.noreply.github.com>
Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>
* feat(storybook): initial commit * feat(storybook): add radio group docs * fix(ui): add feedback * fix(storybook): change folder name * fix(storybook): filenaming * fix(storybook): import issues * fix(storybook): import issue --------- Co-authored-by: Christian Hoffmann <112889877+ChristianHoffmannS2@users.noreply.github.com>
* feat(storybook): added argTableTypes * feature(storybook): added toggle-switch story * feature(storybook): added various stories * fix(storybook): added changes after review and add name property to component * fix(storybook): change story property order * fix(storybook): added changes after review * fix(storybook): another changes after review * fix(storybook): added changes after review
* fixes tooltip tokens * apply new token names on tooltip-bubble/index.css * Adds tooltip elevation and typo tokens * fix tooltip tokens --------- Co-authored-by: David Kennedy <127498135+davidken91@users.noreply.github.com> Co-authored-by: Christian Hoffmann <112889877+ChristianHoffmannS2@users.noreply.github.com>
faselbaum
removed
the
🦹 needs:reviewers (code)
ChristianHoffmannS2
dismissed
angsherpa456’s stale review
The merge-base changed after approval.
ChristianHoffmannS2
force-pushed
the
develop
branch
2 times, most recently
from
358f467 to
99c0c93
Compare
davidken91
added
the
🦹 needs:reviewers (code)
…x/943-fix-icon-button-events
thrbnhrtmnn
approved these changes
Mar 27, 2024
…x/943-fix-icon-button-events
ashk1996
added a commit
that referenced
this pull request
Jan 6, 2025
* fix(ui-library): harmonize property naming (#940) Co-authored-by: Julius Walther <julius.walther@sinnerschrader.com> * fix(ui-library): fix icon button events (#1018) fix(ui-library): fix icon button events * fix(ui-library): remove margin in error state (#945) (#1060) * docs(getstarted): update getstarted documentation (#1063) Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> * fix(ui-library): align hint and error message icons (#1059) Co-authored-by: Christian Hoffmann <112889877+ChristianHoffmannS2@users.noreply.github.com> Co-authored-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> * docs(contribute): update contributing documentation (#1057) * docs():Update CONTRIBUTING.md Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> * docs(): Update CONTRIBUTING.md Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> * docs(contribute): add full stops and optimize sentences Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> * docs(contribute): update contributing documentation Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> * docs(contribute): update contributing documentation Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> --------- Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> * fix(ui-library): #800 align checkbox props with design (#1058) Co-authored-by: Barkley <barkley.taylor@accenture.com> Co-authored-by: Julius Walther <julius.walther@sinnerschrader.com> Co-authored-by: David Kennedy <david.a.kennedy@accenture.com> * fix(ui-library, storybook): #835 align radio-group prop names with design #1039 Co-authored-by: Barkley <barkley.taylor@accenture.com> Co-authored-by: Julius Walther <julius.walther@sinnerschrader.com> Co-authored-by: David Kennedy <127498135+davidken91@users.noreply.github.com> * fix(ui-library, storybook): #875 align toggle prop names with design (#1022) Co-authored-by: Barkley <barkley.taylor@accenture.com> Co-authored-by: Julius Walther <julius.walther@accenture.com> Co-authored-by: David Kennedy <127498135+davidken91@users.noreply.github.com> * fix(ui-library, storybook): #823 radio - align prop names with design (#962) Co-authored-by: Barkley <barkley.taylor@accenture.com> Co-authored-by: Julius Walther <julius.walther@accenture.com> Co-authored-by: David Kennedy <david.a.kennedy@accenture.com> * fix(ui-library): updating js example app change events with values (#1066) * docs(all): distinguish contributors and core team (#1069) * docs(getstarted): distinguish contributors and core team Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> * docs(contributing): update contributing doc Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> * docs(readme): update readme Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> * docs(getstarted): update team Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> --------- Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> * docs(contributing): update pr process documentation (#1074) * docs(contributing): update pr process documentation Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> * docs(contributing): fix typos Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> --------- Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> * fix(ui-library): rename tooltip component (#860) (#1076) * fix(ui-library, tokens): #1014 create & use tokens for inputfield icon (#1036) Co-authored-by: larserbach <larserbach@users.noreply.github.com> * refactor(ui-library): change theming approach (#991) Co-authored-by: Julius Walther <julius.walther@accenture.com> * docs(ui-library): input-field-number, document stepper token usage (#1100) * fix(ui-library): input field text ui fixes (#1101) * fix(ui-library): input field text ui fixes * fix(ui-library): placeholder error state fix and remove border properties * fix(ui-library): reverted disabled as a class and added input color to the associated class * fix(ui-library): added disbaled to inner class * docs(getstarted): fixed a typo in dev lead touchpoint description (#1104) docs(getstarted): fixed a typo in dev lead touchpoint description Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> * fix(ui-library): select component size fixed (#1102) * fix(ui-library): select component size fixed * fix(ui-library): remove border and replace by outline for select componet * fix(ui-library): input field text ui fixes (#1101) * fix(ui-library): input field text ui fixes * fix(ui-library): placeholder error state fix and remove border properties * fix(ui-library): reverted disabled as a class and added input color to the associated class * fix(ui-library): added disbaled to inner class * fix(ui-library): add outline and removed pressed state for select component --------- Co-authored-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> * fix(ui): adjust links (#1094) * fix(ui): adjust links * fix(ui): correct issues * fix(ui): review comments * fix(ui): review changes * fix(ui-library): align counter to right for text area with or without error (#1105) * fix(ui-library): align counter to right for text area with or without error * fix(ui-library): test case fixed * fix(ui-library): added new test cases for text area component * fix(ui-library): changed css structure for consistency * fix(ui-library): removed extra space and rebased with develop * fix(ui-library): added error message class for simplified styling * fix(ui-library): align counter to the right when hint message is empty * fix(tokens): #1032 improve contrast (#1110) * fix sys.disabled sem.buttons.silent cmp.stepperbutton * adds surface colors * fix danger color inverted dark * fix(ui-library): #971 align casing of tokens (part 1) (#1111) * init * renames blanket and captionGroup * renames captioncomponent -> formcaption * replaces underscrore with hyphens @ formacaption * replace hyphens with underscore * refactor style-dictionary config * fix form-caption index.css * fixes uppercase leftovers * all checbox tokens lower case * fix borderWidth tokenns at checkbox * renames sys sizing tokens to lower case * lowercase Checkbox and formlabel * checkbox size variant to lower case * fix checkbox indes.css * fix form caption group * fix toggle switch and radio * fix forms * fix checkbox size variants in index.ts * refactor sorting json * counter tokens to lower case * counter tokens to lower case * counter tokens to lower case * fix counter index css * fix(ci): don't override yarn version defined in .yarnrc (#1116) * feat(storybook): remove hasIcon/Unit props (#1092) * feat(storybook): remove hasIcon/Unit props --------- Co-authored-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> * fix(ui-library): #1120 fix checkbox in js example app (#1121) * feat(storybook): add a11y config (#1124) * fix(storybook): checkbox size issue (#1123) * fix(storybook): checkbox size issue * fix(storybook): removee border css (#1126) * feat(all): #1096 ssr (#1103) * refactor(ui-library): #1081 css tooling lit (#1095) * refactor(ui-library): change css tooling for validation and vscode intellisense * refactor(ui-library): adapt css to make use of new tooling configuration * fix(ui-library): fix stylelint errors * fix(ui-library): remove slot from select component (#1131) * fix(storybook): increase clickable area (#1130) * feat(ui-library): radio group - use slots instead of options array (#1079) * fix(ui-library): radio group size fix (#1139) (#1140) * feat(ui-library): tab bar - use slots for tab bar item (#1136) Co-authored-by: Barkley <barkley.taylor@accenture.com> * docs(getstarted): update getstarted (#1144) * docs: add disclaimers and update getstarted - split meetings into regular, optional and paused in getstarted doc - updated team overview in getstarted doc - added disclaimer for forked repositories to getstarted doc Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> * docs: remove disclaimer - removed disclaimer again from getstarted page Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> --------- Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> * fix(docs): marketing weekly (#1146) marketing weekly is a bi-weekly now Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> * fix(ui-library): accessibility issue for text area background color (#1106) * fix(ui-library): accessibility issue for background color fixed for text area fix(ui-library): removed extra class and refactored css for text area * fix(ui-library): added missing semicolon * fix(ui-library): fixed eslint errors * fix(ui-library): remove slot from select component (#1131) * fix(storybook): increase clickable area (#1130) * feat(ui-library): radio group - use slots instead of options array (#1079) * fix(ui-library): radio group size fix (#1139) (#1140) * fix(ui-library): fixed css error state * fix(ui-library): updated package * fix(ui-library): updated package --------- Co-authored-by: Ang Dawa Sherpa <89925822+angsherpa456@users.noreply.github.com> Co-authored-by: Barkley <78202031+bar-tay@users.noreply.github.com> * feat(storybook): select icon clickable (#1133) * feat(storybook): wip * fix(storybook): add open options on icon click * fix(storybook): wip * fix(storybook): delete centered layout --------- Co-authored-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> * feat(storybook): use outline instead of border (#1137) * feat(storybook): use outline instead of border * feat(ui): add offset * fix(storybook): adjust outline * fix(storybook): adjust outline * fix(storybook): wip * fix(storybook): wip * fix(storybook): wip * fix(storybook): wip * fix(storybook): add functionality (#1147) * fix(storybook): add functionality * fix(storybook): textarea size limitations * fix(storybook): add row describtion * fix(storybook): review changes --------- Co-authored-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> * fix(ui-library): checkbox component fixes (#1148) Co-authored-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> * fix(storybook): diable resize function (#1149) Co-authored-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> * fix(ui-library): component toggle-switch fixes (#1151) * fix(ui-library): checking pr * fix(ui-library): toggle switch component fixes * fix(ui-library): add hover states for active and inactive states * fix(ui-library): add more hover states for active and inactive states * fix(ui-library): update button icon and text test cases * fix(ui-library): input field number unit test case fixed * fix(ui-library): removed unused variable * fix(ui-library): add disabled and readonly state colors * fix(ui-library): pressed state and state changes fixed * fix(ui-library): eslint add new line * fix(tokens): #971 align casing of tokens pt2 (#1132) * renames stepperbutton tokens * renames icon tokens * renames stepperbutton border token * updates stepperbutton and icon index.css - lowercase everywhere * fix: dialog tokens * rename backgroundcolor -> bgcolor * feat: adds some internal figma only colors. * fix: color value * fix: counter text neutral receives correct token * fix(tokens): reduces inverse colors and rearanges some path items * fix toggleSwitch css and tabbar iconSizeVariant --------- Signed-off-by: larserbach <larserbach@users.noreply.github.com> * initial (#1159) * fix(all): #1153 switch to DTCG token format & migrate to latest styledictionary and ts-transform (#1160) * using SD v4.00 and latest tokenStudio transforms * adds function to write themes_generated.cjs * removes themes.mjs * dynamically generated theme names and utilize them * renames theme: light -> light_value * renames theme: dark -> dark_value * moves radios.css into radio and radio-group directories * fix(ui-library): removed readonly state for checkbox radio radiogroup and toggle switch (#1167) * fix(ui-library): removed readonly state for checkbox radio radiogroup and toggle switch * rmv readonly tokens from checkbox, radio, radiogroup and toggleswitch * fixes radio css --------- Co-authored-by: Lars Erbach <larserbach@users.noreply.github.com> * fix(tokens): #1168 move typotokens into sym (#1169) * fix semantic typo * fix: use sys tokens in component tokens * fix: moves elevations to sys * fixing inverse colors * fix(storybook): Input field number adjustment (#1152) * fix(storybook): readonly & disabled state * fix(storybook): readonly & disabled state * fix(storybook): button tests * fix(storybook): width of horizontal stepper * fix(storybook): fix background, value & unit color * fix(storybook): native stepper is shown in firefox * fix(ui): test issue * fix(ui): apply lowercase tokens * fix(ui): color and size review --------- Co-authored-by: Lars Erbach <larserbach@users.noreply.github.com> * fix(ui-library): type errors fixed for lint analyze pipeline (#1171) * fix(ui-library): type errors fixed for lint analyze pipeline * fix(ui-library): fix eslint issue * feat(ci): improving release process using release-please (#1176) * feat(ui-library): introduce property sanitizer using preact and controller (#1175) * fix(ui-library): changed default params of value (#1173) * fix(ui-library): changed default params of value fix(ui-library): update value on readonly * fix(ui-library): type errors fixed for lint analyze pipeline (#1171) * fix(ui-library): type errors fixed for lint analyze pipeline * fix(ui-library): fix eslint issue * fix(ui-library): changed to develop code * fix(ui-library): update value on readonly --------- Signed-off-by: ashk1996 <125904756+ashk1996@users.noreply.github.com> * feat(tokens): use dynamic imports generate-json-structure.mjs for new theme approach (#1178) Co-authored-by: larserbach <larserbach@users.noreply.github.com> --------- Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> Signed-off-by: larserbach <larserbach@users.noreply.github.com> Signed-off-by: ashk1996 <125904756+ashk1996@users.noreply.github.com> Co-authored-by: JpunktWpunkt <92968754+JpunktWpunkt@users.noreply.github.com> Co-authored-by: Julius Walther <julius.walther@sinnerschrader.com> Co-authored-by: David Kennedy <127498135+davidken91@users.noreply.github.com> Co-authored-by: Ang Dawa Sherpa <89925822+angsherpa456@users.noreply.github.com> Co-authored-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> Co-authored-by: RubirajAccenture <122974571+RubirajAccenture@users.noreply.github.com> Co-authored-by: Christian Hoffmann <112889877+ChristianHoffmannS2@users.noreply.github.com> Co-authored-by: Barkley <78202031+bar-tay@users.noreply.github.com> Co-authored-by: Barkley <barkley.taylor@accenture.com> Co-authored-by: David Kennedy <david.a.kennedy@accenture.com> Co-authored-by: Julius Walther <julius.walther@accenture.com> Co-authored-by: Julius Walther <juliuswalther1991@googlemail.com> Co-authored-by: larserbach <larserbach@users.noreply.github.com>
ChristianHoffmannS2
pushed a commit
that referenced
this pull request
Jan 13, 2025
fix(ui-library): fix icon button events
ashk1996
added a commit
that referenced
this pull request
Jan 13, 2025
* fix(ui-library): harmonize property naming (#940) Co-authored-by: Julius Walther <julius.walther@sinnerschrader.com> * fix(ui-library): fix icon button events (#1018) fix(ui-library): fix icon button events * fix(ui-library): remove margin in error state (#945) (#1060) * docs(getstarted): update getstarted documentation (#1063) Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> * fix(ui-library): align hint and error message icons (#1059) Co-authored-by: Christian Hoffmann <112889877+ChristianHoffmannS2@users.noreply.github.com> Co-authored-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> * docs(contribute): update contributing documentation (#1057) * docs():Update CONTRIBUTING.md Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> * docs(): Update CONTRIBUTING.md Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> * docs(contribute): add full stops and optimize sentences Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> * docs(contribute): update contributing documentation Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> * docs(contribute): update contributing documentation Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> --------- Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> * fix(ui-library): #800 align checkbox props with design (#1058) Co-authored-by: Barkley <barkley.taylor@accenture.com> Co-authored-by: Julius Walther <julius.walther@sinnerschrader.com> Co-authored-by: David Kennedy <david.a.kennedy@accenture.com> * fix(ui-library, storybook): #835 align radio-group prop names with design #1039 Co-authored-by: Barkley <barkley.taylor@accenture.com> Co-authored-by: Julius Walther <julius.walther@sinnerschrader.com> Co-authored-by: David Kennedy <127498135+davidken91@users.noreply.github.com> * fix(ui-library, storybook): #875 align toggle prop names with design (#1022) Co-authored-by: Barkley <barkley.taylor@accenture.com> Co-authored-by: Julius Walther <julius.walther@accenture.com> Co-authored-by: David Kennedy <127498135+davidken91@users.noreply.github.com> * fix(ui-library, storybook): #823 radio - align prop names with design (#962) Co-authored-by: Barkley <barkley.taylor@accenture.com> Co-authored-by: Julius Walther <julius.walther@accenture.com> Co-authored-by: David Kennedy <david.a.kennedy@accenture.com> * fix(ui-library): updating js example app change events with values (#1066) * docs(all): distinguish contributors and core team (#1069) * docs(getstarted): distinguish contributors and core team Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> * docs(contributing): update contributing doc Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> * docs(readme): update readme Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> * docs(getstarted): update team Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> --------- Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> * docs(contributing): update pr process documentation (#1074) * docs(contributing): update pr process documentation Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> * docs(contributing): fix typos Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> --------- Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> * fix(ui-library): rename tooltip component (#860) (#1076) * fix(ui-library, tokens): #1014 create & use tokens for inputfield icon (#1036) Co-authored-by: larserbach <larserbach@users.noreply.github.com> * refactor(ui-library): change theming approach (#991) Co-authored-by: Julius Walther <julius.walther@accenture.com> * docs(ui-library): input-field-number, document stepper token usage (#1100) * fix(ui-library): input field text ui fixes (#1101) * fix(ui-library): input field text ui fixes * fix(ui-library): placeholder error state fix and remove border properties * fix(ui-library): reverted disabled as a class and added input color to the associated class * fix(ui-library): added disbaled to inner class * docs(getstarted): fixed a typo in dev lead touchpoint description (#1104) docs(getstarted): fixed a typo in dev lead touchpoint description Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> * fix(ui-library): select component size fixed (#1102) * fix(ui-library): select component size fixed * fix(ui-library): remove border and replace by outline for select componet * fix(ui-library): input field text ui fixes (#1101) * fix(ui-library): input field text ui fixes * fix(ui-library): placeholder error state fix and remove border properties * fix(ui-library): reverted disabled as a class and added input color to the associated class * fix(ui-library): added disbaled to inner class * fix(ui-library): add outline and removed pressed state for select component --------- Co-authored-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> * fix(ui): adjust links (#1094) * fix(ui): adjust links * fix(ui): correct issues * fix(ui): review comments * fix(ui): review changes * fix(ui-library): align counter to right for text area with or without error (#1105) * fix(ui-library): align counter to right for text area with or without error * fix(ui-library): test case fixed * fix(ui-library): added new test cases for text area component * fix(ui-library): changed css structure for consistency * fix(ui-library): removed extra space and rebased with develop * fix(ui-library): added error message class for simplified styling * fix(ui-library): align counter to the right when hint message is empty * fix(tokens): #1032 improve contrast (#1110) * fix sys.disabled sem.buttons.silent cmp.stepperbutton * adds surface colors * fix danger color inverted dark * fix(ui-library): #971 align casing of tokens (part 1) (#1111) * init * renames blanket and captionGroup * renames captioncomponent -> formcaption * replaces underscrore with hyphens @ formacaption * replace hyphens with underscore * refactor style-dictionary config * fix form-caption index.css * fixes uppercase leftovers * all checbox tokens lower case * fix borderWidth tokenns at checkbox * renames sys sizing tokens to lower case * lowercase Checkbox and formlabel * checkbox size variant to lower case * fix checkbox indes.css * fix form caption group * fix toggle switch and radio * fix forms * fix checkbox size variants in index.ts * refactor sorting json * counter tokens to lower case * counter tokens to lower case * counter tokens to lower case * fix counter index css * fix(ci): don't override yarn version defined in .yarnrc (#1116) * feat(storybook): remove hasIcon/Unit props (#1092) * feat(storybook): remove hasIcon/Unit props --------- Co-authored-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> * fix(ui-library): #1120 fix checkbox in js example app (#1121) * feat(storybook): add a11y config (#1124) * fix(storybook): checkbox size issue (#1123) * fix(storybook): checkbox size issue * fix(storybook): removee border css (#1126) * feat(all): #1096 ssr (#1103) * refactor(ui-library): #1081 css tooling lit (#1095) * refactor(ui-library): change css tooling for validation and vscode intellisense * refactor(ui-library): adapt css to make use of new tooling configuration * fix(ui-library): fix stylelint errors * fix(ui-library): remove slot from select component (#1131) * fix(storybook): increase clickable area (#1130) * feat(ui-library): radio group - use slots instead of options array (#1079) * fix(ui-library): radio group size fix (#1139) (#1140) * feat(ui-library): tab bar - use slots for tab bar item (#1136) Co-authored-by: Barkley <barkley.taylor@accenture.com> * docs(getstarted): update getstarted (#1144) * docs: add disclaimers and update getstarted - split meetings into regular, optional and paused in getstarted doc - updated team overview in getstarted doc - added disclaimer for forked repositories to getstarted doc Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> * docs: remove disclaimer - removed disclaimer again from getstarted page Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> --------- Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> * fix(docs): marketing weekly (#1146) marketing weekly is a bi-weekly now Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> * fix(ui-library): accessibility issue for text area background color (#1106) * fix(ui-library): accessibility issue for background color fixed for text area fix(ui-library): removed extra class and refactored css for text area * fix(ui-library): added missing semicolon * fix(ui-library): fixed eslint errors * fix(ui-library): remove slot from select component (#1131) * fix(storybook): increase clickable area (#1130) * feat(ui-library): radio group - use slots instead of options array (#1079) * fix(ui-library): radio group size fix (#1139) (#1140) * fix(ui-library): fixed css error state * fix(ui-library): updated package * fix(ui-library): updated package --------- Co-authored-by: Ang Dawa Sherpa <89925822+angsherpa456@users.noreply.github.com> Co-authored-by: Barkley <78202031+bar-tay@users.noreply.github.com> * feat(storybook): select icon clickable (#1133) * feat(storybook): wip * fix(storybook): add open options on icon click * fix(storybook): wip * fix(storybook): delete centered layout --------- Co-authored-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> * feat(storybook): use outline instead of border (#1137) * feat(storybook): use outline instead of border * feat(ui): add offset * fix(storybook): adjust outline * fix(storybook): adjust outline * fix(storybook): wip * fix(storybook): wip * fix(storybook): wip * fix(storybook): wip * fix(storybook): add functionality (#1147) * fix(storybook): add functionality * fix(storybook): textarea size limitations * fix(storybook): add row describtion * fix(storybook): review changes --------- Co-authored-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> * fix(ui-library): checkbox component fixes (#1148) Co-authored-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> * fix(storybook): diable resize function (#1149) Co-authored-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> * fix(ui-library): component toggle-switch fixes (#1151) * fix(ui-library): checking pr * fix(ui-library): toggle switch component fixes * fix(ui-library): add hover states for active and inactive states * fix(ui-library): add more hover states for active and inactive states * fix(ui-library): update button icon and text test cases * fix(ui-library): input field number unit test case fixed * fix(ui-library): removed unused variable * fix(ui-library): add disabled and readonly state colors * fix(ui-library): pressed state and state changes fixed * fix(ui-library): eslint add new line * fix(tokens): #971 align casing of tokens pt2 (#1132) * renames stepperbutton tokens * renames icon tokens * renames stepperbutton border token * updates stepperbutton and icon index.css - lowercase everywhere * fix: dialog tokens * rename backgroundcolor -> bgcolor * feat: adds some internal figma only colors. * fix: color value * fix: counter text neutral receives correct token * fix(tokens): reduces inverse colors and rearanges some path items * fix toggleSwitch css and tabbar iconSizeVariant --------- Signed-off-by: larserbach <larserbach@users.noreply.github.com> * initial (#1159) * fix(all): #1153 switch to DTCG token format & migrate to latest styledictionary and ts-transform (#1160) * using SD v4.00 and latest tokenStudio transforms * adds function to write themes_generated.cjs * removes themes.mjs * dynamically generated theme names and utilize them * renames theme: light -> light_value * renames theme: dark -> dark_value * moves radios.css into radio and radio-group directories * fix(ui-library): removed readonly state for checkbox radio radiogroup and toggle switch (#1167) * fix(ui-library): removed readonly state for checkbox radio radiogroup and toggle switch * rmv readonly tokens from checkbox, radio, radiogroup and toggleswitch * fixes radio css --------- Co-authored-by: Lars Erbach <larserbach@users.noreply.github.com> * fix(tokens): #1168 move typotokens into sym (#1169) * fix semantic typo * fix: use sys tokens in component tokens * fix: moves elevations to sys * fixing inverse colors * fix(storybook): Input field number adjustment (#1152) * fix(storybook): readonly & disabled state * fix(storybook): readonly & disabled state * fix(storybook): button tests * fix(storybook): width of horizontal stepper * fix(storybook): fix background, value & unit color * fix(storybook): native stepper is shown in firefox * fix(ui): test issue * fix(ui): apply lowercase tokens * fix(ui): color and size review --------- Co-authored-by: Lars Erbach <larserbach@users.noreply.github.com> * fix(ui-library): type errors fixed for lint analyze pipeline (#1171) * fix(ui-library): type errors fixed for lint analyze pipeline * fix(ui-library): fix eslint issue * feat(ci): improving release process using release-please (#1176) * feat(ui-library): introduce property sanitizer using preact and controller (#1175) * fix(ui-library): changed default params of value (#1173) * fix(ui-library): changed default params of value fix(ui-library): update value on readonly * fix(ui-library): type errors fixed for lint analyze pipeline (#1171) * fix(ui-library): type errors fixed for lint analyze pipeline * fix(ui-library): fix eslint issue * fix(ui-library): changed to develop code * fix(ui-library): update value on readonly --------- Signed-off-by: ashk1996 <125904756+ashk1996@users.noreply.github.com> * feat(tokens): use dynamic imports generate-json-structure.mjs for new theme approach (#1178) Co-authored-by: larserbach <larserbach@users.noreply.github.com> * feat(chor): package json version number needs to be correct for release-please to work * feat(chor): set up pre release setting * Revert "feat(chor): set up pre release setting" This reverts commit 106b220. * fix(versioning): no major bumps when under version 1.x * fix(versioning): no major bumps for now * fix(versioning): no major bumps for now * fix(versioning): no major bumps for now * feat(ci): minor version bump force * fix(ui-library): pressed state removed and updated focus state for readonly (#1172) * fix(ui-library): pressed state removed and updated focus state for readonly * fix(ui-library): updated focus and hover state for text area and input field * fix(ui-library): eslint fix * fix: deletes all sem.inputfields....pressed tokens * fix: deletes inputflield border tokens pressed * fix: removed active states from css --------- Co-authored-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> Co-authored-by: Lars Erbach <larserbach@users.noreply.github.com> * fix: removes range slider files, tokens and references * chore: release 0.4.0 Release-As: 0.4.0 * feat(release): trigger release using release please bot on dev branch (#1208) * feat(release): trigger release using release please bot on dev branch * chore(release): release v0.4.0 * feat(release): updated doc and release please pipeline * feat(ci): update release pipeline * feat(release): updated release workflow to trigger pr from main * fix(release): test * chore(release): implement release pelase workflow * chore(docs): documentation update for release workflow * feat(tokens): adds index-generator (#1204) * feat: adds index-generator * fix: file namings --------- Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> Signed-off-by: larserbach <larserbach@users.noreply.github.com> Signed-off-by: ashk1996 <125904756+ashk1996@users.noreply.github.com> Co-authored-by: JpunktWpunkt <92968754+JpunktWpunkt@users.noreply.github.com> Co-authored-by: Julius Walther <julius.walther@sinnerschrader.com> Co-authored-by: David Kennedy <127498135+davidken91@users.noreply.github.com> Co-authored-by: Ang Dawa Sherpa <89925822+angsherpa456@users.noreply.github.com> Co-authored-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> Co-authored-by: RubirajAccenture <122974571+RubirajAccenture@users.noreply.github.com> Co-authored-by: Christian Hoffmann <112889877+ChristianHoffmannS2@users.noreply.github.com> Co-authored-by: Barkley <78202031+bar-tay@users.noreply.github.com> Co-authored-by: Barkley <barkley.taylor@accenture.com> Co-authored-by: David Kennedy <david.a.kennedy@accenture.com> Co-authored-by: Julius Walther <julius.walther@accenture.com> Co-authored-by: Julius Walther <juliuswalther1991@googlemail.com> Co-authored-by: larserbach <larserbach@users.noreply.github.com> Co-authored-by: christian.b.hoffmann <christian.b.hoffmann@accenture.com>
ChristianHoffmannS2
pushed a commit
that referenced
this pull request
Jan 13, 2025
fix(ui-library): fix icon button events
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.