Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form Label Inline - remove component in code #1000

Open
1 of 4 tasks
Tracked by #452
thrbnhrtmnn opened this issue Mar 8, 2024 · 3 comments
Open
1 of 4 tasks
Tracked by #452

Form Label Inline - remove component in code #1000

thrbnhrtmnn opened this issue Mar 8, 2024 · 3 comments
Labels
🚫 blocked This issue is blocked ⭕ core team issue This is for the core team and should not be done by contributors ⌨️ dev issue Task is for developers 📋 task::ready Task is ready to be picked up or planned in

Comments

@thrbnhrtmnn
Copy link
Contributor

thrbnhrtmnn commented Mar 8, 2024

Description / User story

The form label inline is not a component we have in design. Therefor it should be checked if we can remove it in code.

A quick search in the backlog lead to #287 , where we discussed inline functionality for the form label. If this was the reason why there are 2 Form Label components in code we can just remove the one where the appendix is not inline and name the remaining component Form Label.

When this ticket was created it was missed that #668 already existed. The decision that is part of #668 was already made when we defined the goal to be aligned as much as possible between design and code.

Form Label Inline is used:

  • Radio
  • Checkbox
  • ToggleSwitch

Form Label is used for example in:

  • Text Area

Requirements / Prerequisites

Acceptance Criteria

  • It has been checked if the form label inline component can be removed
  • If it is possible to do so by either combining it with the Form Label or by replacing it with the Form Label and removing it, this has been done.

Additional information

  • ...

Code of Conduct

  • I agree to follow this project's Code of Conduct
@thrbnhrtmnn thrbnhrtmnn added ⌨️ dev issue Task is for developers ⭕ core team issue This is for the core team and should not be done by contributors 🚫 blocked This issue is blocked labels Mar 8, 2024
@thrbnhrtmnn
Copy link
Contributor Author

Hey @davidken91 , do you remember, why we said this task is blocked by #1019 ? I ask, because I would like to move this task up and start working on it soon :-)

@davidken91
Copy link
Contributor

I'm not 100% certain, but I believe that we theoretically have a solution for #1019 but it requires the theming to be finished first. Label and label inline probably shouldn't be separate components since the only difference between them is if they are block aligned, or inline aligned. I'm guessing that label inline should only be removed when we have ids working

@thrbnhrtmnn
Copy link
Contributor Author

Okay, that makes sense, thank you!

@thrbnhrtmnn thrbnhrtmnn added the 📋 task::ready Task is ready to be picked up or planned in label Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚫 blocked This issue is blocked ⭕ core team issue This is for the core team and should not be done by contributors ⌨️ dev issue Task is for developers 📋 task::ready Task is ready to be picked up or planned in
Projects
None yet
Development

No branches or pull requests

2 participants