Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New nodes in existing ways persist after deletion in editing mode #321

Closed
LanesGood opened this issue Jun 10, 2020 · 4 comments
Closed

New nodes in existing ways persist after deletion in editing mode #321

LanesGood opened this issue Jun 10, 2020 · 4 comments
Labels
bug Something isn't working
Milestone

Comments

@LanesGood
Copy link
Member

Adding new nodes to existing ways and then deleting these and surrounding nodes results in strange behaviors. Most of the time, these new nodes are still rendered even when the resulting way is altered. This is difficult to describe exactly how to reproduce, as I'm not sure what exactly is happening. Noting as well that I'm purposefully trying to break things, rather than reproduce a live use case.

new-node-delete-issue

The final result after attempting to save the changeset is also usually a console.error:"Error storing data", Error: database or disk is full (code 13 SQLITE_FULL) - this is on Android AVD,

This seems related to #289 #296 and #318

@LanesGood LanesGood added the bug Something isn't working label Jun 10, 2020
@LanesGood
Copy link
Member Author

EDIT: Far less complex example indicates that this behavior is a consistent bug
new-node-delete-bug

@geohacker
Copy link
Member

@LanesGood nice catch. I think I know what could be going on here. The node itself is deleted from the feature (notice the change in the shape) but it's not hidden from the map because of a style filter issue. I can fix.

@geohacker
Copy link
Member

console.error:"Error storing data", Error: database or disk is full (code 13 SQLITE_FULL)

This is unrelated to the nodes not getting deleted. This likely means the AVD hit the limit for async-storage. A reset should fix it.

@geohacker
Copy link
Member

This is fixed in #322

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants