Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't show Upload All button on User Contributions if no pending edits #20

Closed
batpad opened this issue Apr 24, 2019 · 1 comment · Fixed by #124
Closed

Don't show Upload All button on User Contributions if no pending edits #20

batpad opened this issue Apr 24, 2019 · 1 comment · Fixed by #124
Assignees
@batpad @kamicut
Labels
ui
Milestone
production-release

Comments

@batpad
Copy link
Member

batpad commented Apr 24, 2019

Currently, the Retry / Upload All icon shows on User Contributions even when the user has no pending edits to upload. We should hide the button if there are no pending or currently uploading edits.
@batpad batpad self-assigned this Apr 24, 2019
@geohacker geohacker transferred this issue from another repository May 13, 2019
@geohacker geohacker added this to the production-release milestone May 16, 2019
@sethvincent sethvincent added the ui label Jun 5, 2019
@kamicut
Copy link
Member

kamicut commented Jun 19, 2019

What about the trash icon? Should it be hidden if there are no uploaded edits?

@geohacker geohacker mentioned this issue Jul 3, 2019
Merged
@geohacker geohacker mentioned this issue Nov 4, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@batpad batpad

@kamicut kamicut

Labels
ui
Projects
None yet
Milestone
production-release
Development

Successfully merging a pull request may close this issue.

hide upload and trash buttons if there are no edits developmentseed/observe
4 participants
@batpad @sethvincent @geohacker @kamicut