You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I can't really say that I understand why this was done in the first place, so don't want to go "fixing" it as there might be some relying on this. To me, it seems like that in the absence of the output flag, these fields should be read and used exactly, no replacing.
mainNoExtension seems like it should be the last of the fallbacks, not something that overwrites valid entries & chosen names.
The text was updated successfully, but these errors were encountered:
Packages that don't use the
output
flag or have a"main"
in theirpackage.json
have their preferred filename output ignored.For example, say I have the following package:
Unfortunately, because of the
replaceName()
here, the desired output is replaced by the package name instead.microbundle/src/index.js
Lines 297 to 303 in b1a6374
microbundle/src/index.js
Lines 255 to 260 in b1a6374
mainNoExtension
traces back to here, which defines a couple of fallbacks.microbundle/src/index.js
Lines 219 to 225 in b1a6374
I can't really say that I understand why this was done in the first place, so don't want to go "fixing" it as there might be some relying on this. To me, it seems like that in the absence of the
output
flag, these fields should be read and used exactly, no replacing.mainNoExtension
seems like it should be the last of the fallbacks, not something that overwrites valid entries & chosen names.The text was updated successfully, but these errors were encountered: