Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two problems in vsf-payment-paypal/API/paypal/index.js #127

Open
ldc321 opened this issue Jun 13, 2020 · 3 comments
Open

Two problems in vsf-payment-paypal/API/paypal/index.js #127

ldc321 opened this issue Jun 13, 2020 · 3 comments

Comments

@ldc321
Copy link

ldc321 commented Jun 13, 2020

image

if discount > 1000 , get error !
'PAYMENTREQUEST_0_SHIPDISCAMT': '-' + paypalNVP.formatCurrency(pay.purchase_units[0].amount.breakdown.discount.value),

  1. line 108

tmp["L_PAYMENTREQUEST_0_AMT" + i] = paypalNVP.formatCurrency(p.unit_amount.value);

if AMT_i == 0 , get error
tmp['L_PAYMENTREQUEST_0_AMT' + i] = p.unit_amount.value ? paypalNVP.formatCurrency(p.unit_amount.value) : "0.00";

@dimasch
Copy link
Contributor

dimasch commented Jun 14, 2020

@ldc321 Thanks.
Welcome to pull request!

@ldc321
Copy link
Author

ldc321 commented Aug 6, 2020

@ldc321 Thanks.
Welcome to pull request!

I have a vue-storefront project, The vsf-payment-paypal API is used! It's a great project. But there are more payment methods we need to develop such as sofort , giropay, eps,payssion,payfast and so on! If so, I wonder if I can buy these plug-ins. Looking forward to your reply

@dimasch
Copy link
Contributor

dimasch commented Aug 13, 2020

@ldc321 Ok, thanks. I will upgrade current to new 1.12.x signatures and will support for the Capybara theme. In next time i will check sofort , giropay, eps, payssion, payfast etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants