From f47572f1e8d955d506a73a0001c4b97ffd026f12 Mon Sep 17 00:00:00 2001
From: Shaurya <agarwal.lucky.shaurya11@gmail.com>
Date: Tue, 3 Jan 2023 23:59:26 +0530
Subject: [PATCH] fix: fixed romStatement parsing to parse quotes in variable
 expressions

---
 src/spec-node/dockerfileUtils.ts | 16 +++++++--
 src/test/dockerfileUtils.test.ts | 61 ++++++++++++++++++++++++++++++++
 2 files changed, 74 insertions(+), 3 deletions(-)

diff --git a/src/spec-node/dockerfileUtils.ts b/src/spec-node/dockerfileUtils.ts
index 3e41d4ae0..82b78be7d 100644
--- a/src/spec-node/dockerfileUtils.ts
+++ b/src/spec-node/dockerfileUtils.ts
@@ -11,9 +11,9 @@ export { CLIHostDocuments, Documents, createDocuments, Edit, fileDocuments, Remo
 
 
 const findFromLines = new RegExp(/^(?<line>\s*FROM.*)/, 'gm');
-const parseFromLine = /FROM\s+(?<platform>--platform=\S+\s+)?"?(?<image>[^\s"]+)"?(\s+[Aa][Ss]\s+(?<label>[^\s]+))?/;
+const parseFromLine = /FROM\s+(?<platform>--platform=\S+\s+)?(?<image>"?[^\s]+"?)(\s+[Aa][Ss]\s+(?<label>[^\s]+))?/;
 
-const fromStatement = /^\s*FROM\s+(?<platform>--platform=\S+\s+)?"?(?<image>[^\s"]+)"?(\s+[Aa][Ss]\s+(?<label>[^\s]+))?/m;
+const fromStatement = /^\s*FROM\s+(?<platform>--platform=\S+\s+)?(?<image>"?[^\s]+"?)(\s+[Aa][Ss]\s+(?<label>[^\s]+))?/m;
 const argEnvUserStatements = /^\s*(?<instruction>ARG|ENV|USER)\s+(?<name>[^\s=]+)([ =]+("(?<value1>\S+)"|(?<value2>\S+)))?/gm;
 const directives = /^\s*#\s*(?<name>\S+)\s*=\s*(?<value>.+)/;
 
@@ -46,13 +46,23 @@ export interface Instruction {
 	value: string | undefined;
 }
 
+function parseFromStatement(line: string): From {
+  const match = fromStatement.exec(line);
+  if (!match) {
+    return { image: 'unknown' };
+  }
+  let { platfrom, image, label } = match.groups as unknown as From;
+  image = image.replace(/^['"]|['"]$/g, ''); // remove quotes
+  return { platfrom, image, label };
+}
+
 export function extractDockerfile(dockerfile: string): Dockerfile {
 	const fromStatementsAhead = /(?=^[\t ]*FROM)/gm;
 	const parts = dockerfile.split(fromStatementsAhead);
 	const preambleStr = fromStatementsAhead.test(parts[0] || '') ? '' : parts.shift()!;
 	const stageStrs = parts;
 	const stages = stageStrs.map(stageStr => ({
-		from: fromStatement.exec(stageStr)?.groups as unknown as From || { image: 'unknown' },
+		from: parseFromStatement(stageStr),
 		instructions: extractInstructions(stageStr),
 	}));
 	const directives = extractDirectives(preambleStr);
diff --git a/src/test/dockerfileUtils.test.ts b/src/test/dockerfileUtils.test.ts
index f3984867d..6435fdc4c 100644
--- a/src/test/dockerfileUtils.test.ts
+++ b/src/test/dockerfileUtils.test.ts
@@ -306,6 +306,67 @@ FROM \${cloud:-mcr.microsoft.com/}azure-cli:latest
             const image = findBaseImage(extracted, {}, undefined);
             assert.strictEqual(image, 'mcr.microsoft.com/azure-cli:latest');
         });
+
+        describe('Quoted', async () => {
+          it('Positive variable expression with value specified', async () => {
+            const dockerfile = `
+ARG cloud
+FROM \${cloud:+"mcr.microsoft.com/"}azure-cli:latest"
+`;
+            const extracted = extractDockerfile(dockerfile);
+            assert.strictEqual(extracted.stages.length, 1);
+            const image = findBaseImage(
+              extracted,
+              {
+                cloud: 'true',
+              },
+              undefined
+            );
+            assert.strictEqual(image, 'mcr.microsoft.com/azure-cli:latest');
+          });
+
+          it('Positive variable expression with no value specified', async () => {
+            const dockerfile = `
+ARG cloud
+FROM "\${cloud:+"mcr.microsoft.com/"}azure-cli:latest"
+`;
+
+            const extracted = extractDockerfile(dockerfile);
+            assert.strictEqual(extracted.stages.length, 1);
+            const image = findBaseImage(extracted, {}, undefined);
+            assert.strictEqual(image, 'azure-cli:latest');
+          });
+
+          it('Negative variable expression with value specified', async () => {
+            const dockerfile = `
+ARG cloud
+FROM "\${cloud:-"mcr.microsoft.com/"}azure-cli:latest"
+`;
+
+            const extracted = extractDockerfile(dockerfile);
+            assert.strictEqual(extracted.stages.length, 1);
+            const image = findBaseImage(
+              extracted,
+              {
+                cloud: 'ghcr.io/',
+              },
+              undefined
+            );
+            assert.strictEqual(image, 'ghcr.io/azure-cli:latest');
+          });
+
+          it('Negative variable expression with no value specified', async () => {
+            const dockerfile = `
+ARG cloud
+FROM \${cloud:-"mcr.microsoft.com/"}azure-cli:latest as label
+`;
+
+            const extracted = extractDockerfile(dockerfile);
+            assert.strictEqual(extracted.stages.length, 1);
+            const image = findBaseImage(extracted, {}, undefined);
+            assert.strictEqual(image, 'mcr.microsoft.com/azure-cli:latest');
+          });
+        });
     });
 });