Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show local currency in place of € or £ #632

Closed
3 tasks done
priyavrat-misra opened this issue Jan 27, 2024 · 7 comments · Fixed by #636
Closed
3 tasks done

Show local currency in place of € or £ #632

priyavrat-misra opened this issue Jan 27, 2024 · 7 comments · Fixed by #636
Labels
enhancement New feature or request

Comments

@priyavrat-misra
Copy link
Contributor

  • Did you check to see if this issue already exists?
  • Is this only a single feature request? Do not put multiple feature requests in one issue.
  • Is this a question or discussion? Don't use this, use https://lemmy.ml/c/thumbkey

Describe the feature request below

SwipeDirection.BOTTOM_RIGHT to
KeyC(
display = KeyDisplay.TextDisplay(""),
action = KeyAction.CommitText(""),
color = ColorVariant.MUTED,
),

Here's something that came to my mind (didn't try out).

val currency = NumberFormat.getCurrencyInstance(Locale.getDefault()).currency?.symbol ?: ""

// ...

 SwipeDirection.BOTTOM_RIGHT to 
     KeyC( 
         display = KeyDisplay.TextDisplay(currency),
         action = KeyAction.CommitText(currency),
         color = ColorVariant.MUTED,
     ),
@priyavrat-misra priyavrat-misra added the enhancement New feature or request label Jan 27, 2024
@priyavrat-misra priyavrat-misra changed the title Show local currency instead of € Show local currency in place of € or £ Jan 27, 2024
@KraXen72
Copy link
Contributor

i think $, € and £ should stay, as they're pretty common. there could be a wildcard local currency swipe in the numpad elsewhere though

@dessalines
Copy link
Owner

Agree, a new spot for the wildcard currency would be good. @priyavrat-misra feel free to submit a PR.

@priyavrat-misra
Copy link
Contributor Author

Sorry but what's a "wildcard"? Is it some feature?

@KraXen72
Copy link
Contributor

wildcard would just means that it's like dynamic. for example a URL wildcard could be *.google.com - which means (anything).google.com. In this case, i used 'wildcard' because it could be any currency. but yeah it would just be a swipe which is always the user's current currency. also, possibly only show it if the user's current currency is different than $/€/£ ? no need to have 2 ways to type the same thing imo.

@priyavrat-misra
Copy link
Contributor Author

Got it. Will checkout the code locally and raise a PR.

@priyavrat-misra
Copy link
Contributor Author

Bottom-right to 1 seems like a good spot. Let me know your thoughts before I begin.

@dessalines
Copy link
Owner

Bottom-right to 1 seems like a good spot. Let me know your thoughts before I begin.

Seems good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants