From a592f7ed43c850be663040b22a49cc38beb9f7ae Mon Sep 17 00:00:00 2001 From: Dessalines Date: Thu, 25 Jan 2024 12:21:31 -0500 Subject: [PATCH] Fixing some cursor update issues for multitap. #242 --- .../thumbkey/ui/components/keyboard/KeyboardScreen.kt | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/app/src/main/java/com/dessalines/thumbkey/ui/components/keyboard/KeyboardScreen.kt b/app/src/main/java/com/dessalines/thumbkey/ui/components/keyboard/KeyboardScreen.kt index a5968045d..00c767865 100644 --- a/app/src/main/java/com/dessalines/thumbkey/ui/components/keyboard/KeyboardScreen.kt +++ b/app/src/main/java/com/dessalines/thumbkey/ui/components/keyboard/KeyboardScreen.kt @@ -3,7 +3,6 @@ package com.dessalines.thumbkey.ui.components.keyboard import android.content.Context import android.media.AudioManager import android.util.Log -import android.view.inputmethod.InputConnection.CURSOR_UPDATE_FILTER_INSERTION_MARKER import android.view.inputmethod.InputConnection.CURSOR_UPDATE_MONITOR import androidx.compose.foundation.background import androidx.compose.foundation.border @@ -302,7 +301,11 @@ fun KeyboardScreen( } } } else { - if (ctx.currentInputConnection.requestCursorUpdates(CURSOR_UPDATE_MONITOR or CURSOR_UPDATE_FILTER_INSERTION_MARKER)) { + // NOTE, this should use or CURSOR_UPDATE_FILTER_INSERTION_MARKER , but it doesn't work on + // non-compose textfields. + // This also requires jetpack compose >= 1.6 + // See https://github.com/dessalines/thumb-key/issues/242 + if (ctx.currentInputConnection.requestCursorUpdates(CURSOR_UPDATE_MONITOR)) { Log.d(TAG, "request for cursor updates succeeded, cursor updates will be provided") } else { Log.d(TAG, "request for cursor updates failed, cursor updates will not be provided")