Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace SetupTestInput methods with test suits #198

Closed
RiccardoM opened this issue Jun 18, 2020 · 2 comments · Fixed by #217
Closed

Replace SetupTestInput methods with test suits #198

RiccardoM opened this issue Jun 18, 2020 · 2 comments · Fixed by #217
Assignees
@leobragaz
Labels
quality/tests Improves the test suite
Milestone
v0.9.0

Comments

@RiccardoM
Copy link
Contributor

Looking at the Cosmos SDK codebase it looks like they've swapped all the SetupTestInput methods for easier-to-understand testify.Suite implementations.

I think we should adopt the same strategy, making the tests easier to setup and maintain.
@RiccardoM RiccardoM added the quality/tests Improves the test suite label Jun 18, 2020
@leobragaz
Copy link
Contributor

I will take a look at it soon!

@RiccardoM RiccardoM added this to the v0.9.0 milestone Jun 18, 2020
@RiccardoM
Copy link
Contributor Author

I will take a look at it soon!

Don't rush it, I would target it for v0.9.0, focusing on closing v0.8.0 first.

@leobragaz leobragaz self-assigned this Jun 29, 2020
@RiccardoM RiccardoM assigned leobragaz and unassigned leobragaz Jun 29, 2020
@leobragaz leobragaz mentioned this issue Jul 2, 2020
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leobragaz leobragaz

Labels
quality/tests Improves the test suite
Projects
None yet
Milestone
v0.9.0
Development

Successfully merging a pull request may close this issue.

Replace SetupTestInput with testify test suite desmos-labs/desmos
2 participants
@RiccardoM @leobragaz