Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requesting to include the strong naming for the Scintilla5.Net assembly #142

Closed
KalyaniURS opened this issue Oct 18, 2024 · 5 comments
Closed
Assignees
Labels
enhancement New feature or request

Comments

@KalyaniURS
Copy link

Is your feature request related to a problem? Please describe.
After referencing the Scintilla.NET NuGet package (v5.6.1/v5.6.0) in our project, we encountered a build issue indicating that a strong name is required. Below is the mentioned error occurred while building the solution.

error MC1000: Unknown build error, 'Could not load file or assembly 'Scintilla.NET, Version=5.6.0.0, Culture=neutral, PublicKeyToken=null' or one of its dependencies. A Strongly-named assembly is required. (Exception from HRESULT: 0x80131044)

Describe the solution you'd like
Request to include the strong naming for the assemblies used while referring to the nuget package.

Describe alternatives you've considered

Additional context

@KalyaniURS KalyaniURS added the enhancement New feature or request label Oct 18, 2024
@desjarlais
Copy link
Owner

There is an ongoing discussion about this already:

#100

I think the workaround of forking the repo and making that a signed version would be a better idea than trying to incorporate it into this one...but I am open to other ideas.

@desjarlais desjarlais self-assigned this Oct 20, 2024
@ahmetsait
Copy link
Collaborator

@desjarlais I don't see why signing this lib is such a big deal?

@desjarlais
Copy link
Owner

I haven't researched what it would take to add it to the project so I'll take a look at what that entails. It would be a nice to have, I just haven't looked into the possible issues it could cause yet.

@desjarlais
Copy link
Owner

This should be fixed in 5.6.2

@thehill383
Copy link

came to reserach the exact same issue and found its just been resolved😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants