Track Secrets used by Ingresses #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renan
force-pushed
the
FF_SecretsForIngress
branch
2 times, most recently
from
2e9e194 to
efa0c18
Compare
renan
force-pushed
the
FF_SecretsForIngress
branch
from
efa0c18 to
a8d80f0
Compare
renan
force-pushed
the
FF_SecretsForIngress
branch
from
a8d80f0 to
140973f
Compare
|
@renan Thank you so very much for this PR! Great catch in terms of tracking ingress secrets and for the pluralization. Excellent implementation too! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when running Popeye, I get the issue that certain Secrets are not referenced by other resources but in reality, they are being used by Ingresses.
This Pull Request tracks Secrets used by Ingress and improves the inflection for pluralized words in the report for humans.