Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable over allocation #39

Closed
jclarksnps opened this issue Jun 26, 2019 · 4 comments
Closed

Disable over allocation #39

jclarksnps opened this issue Jun 26, 2019 · 4 comments
Labels
bug Something isn't working

Comments

@jclarksnps
Copy link

jclarksnps commented Jun 26, 2019




Is your feature request related to a problem? Please describe.
The problem is that the over-allocation check is incredibly subjective, since it seems to just grab the current metric for each service. If you want to sanity test a cluster that may have absolutely no load on it, you will always get piles of warnings that are for the most part meaningless. In a sanity test of a cluster's configuration, in some cases you only care about under-allocated as your request/limits are set for real production values.

Describe the solution you'd like
A way to disable the over-allocation test, tried playing with the values and couldn't get it to just go away.

Describe alternatives you've considered
None

Additional context
Add any other context or screenshots about the feature request here.

@derailed
Copy link
Owner

@jclarksnps Thank you for this report! I agree over-allocation warnings yields false positive when the cluster is not under heavy load. I will add an option to silence these in the next drop.

@derailed derailed added the bug Something isn't working label Jun 27, 2019
@whites11
Copy link

I just came by to post exactly the same thought, so +1 here.

@derailed
Copy link
Owner

@jclarksnps @whites11 Fixed v0.3.13!

@whites11
Copy link

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants