Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.27.4 broke custom sort orders via views.yml #2194

Closed
RichieSams opened this issue Aug 11, 2023 · 0 comments · Fixed by #2253
Closed

0.27.4 broke custom sort orders via views.yml #2194

RichieSams opened this issue Aug 11, 2023 · 0 comments · Fixed by #2253
Labels
bug Something isn't working

Comments

@RichieSams
Copy link
Contributor




Describe the bug

In my k9s config folder, I have a views.yml file to change the default sort order of the events view:

k9s:
  views:
    v1/events:
      sortColumn: LAST SEEN:asc
    helm.toolkit.fluxcd.io/v2beta1/helmreleases:
      sortColumn: NAMESPACE:desc

In 0.27.3 or less, the view is correctly rendered, sorting events from most recent, to least recent. But when updating to 0.27.4, the custom sort order is ignored. And the default order, LAST SEEN:desc is used:

0.27.3

0.27.4

To Reproduce
Steps to reproduce the behavior:

  1. Create a views.yml file which changes the sort order of v1/events
  2. Use version 0.27.3, and note that the sort order is correct
  3. Upgrade to 0.27.4 and note that the sort order is ignored

Expected behavior
k9s should use the sort order requested in views.yml

Screenshots
See above

Versions (please complete the following information):

  • OS: Windows and Linux
  • K9s: 0.27.4
  • K8s: Many. But 1.24.14 in the screenshots

Additional context
I looked at the list of commits between 0.27.3 and 0.27.4, and nothing immediately sprung up as a culprit. The only commit that seemed semi-related was this: ab9f960

But I'm not familiar enough with the code to know if that's actually related.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants