-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#52] - 업로드 API 연동 #58
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
🚀 Storybook Deploy : https://67a21b40b49ad2ad0c08c418-bbeckhnhun.chromatic.com/ |
file, | ||
}); | ||
|
||
if (res.url) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
업로드 성공 로직을 TanStack Query에서 제공하는 onSuccess를 활용해도 좋을 거 같아요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
추후 mutateAsync 내부 onSuccess 콜백에서 처리하도록 하겠습니다!
API 호출 함수와 훅을 분리하니 깔끔한 거 같습니다! 해당 방식으로 구현하면 하나의 API 호출 훅을 만들 때마다 두 개의 파일이 생성되는 구조인가요? |
@Limgabi API 호출 함수는 엔드포인트 하나마다 하나의 파일이 생성되고, react query 관련 파일은 단순히 queries.ts, mutations.ts 두 개로 분리하는 걸 생각했습니다! |
🚀 Storybook Deploy : https://67a21b40b49ad2ad0c08c418-ufqliondtu.chromatic.com/ |
2745fcf
to
12c6ef2
Compare
🚀 Storybook Deploy : https://67a21b40b49ad2ad0c08c418-lqjupujzuc.chromatic.com/ |
📌 연관된 이슈 번호
close #52
🌱 주요 변경 사항
🗣 리뷰어에게 할 말 (선택)