[#34] - 사이드바 초기 마크업 생성 및 기존 파일 컨벤션 수정 #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
🚀 Storybook Deploy : https://67a21b40b49ad2ad0c08c418-twfvezzuzq.chromatic.com/ |
Limgabi
reviewed
Feb 18, 2025
|
|
||
| export default function TotalEvalutionPage() { | ||
| const { evaluationSummary, overallEvaluationGrade, evaluationItems } = evaluationData; | ||
| const [isSidebarOpen, setIsSidebarOpen] = useState(true); |
There was a problem hiding this comment.
사이드바 열림 상태를 여러 컴포넌트에서 함께 사용하는 것 같은데, context로 관리하는 것도 좋은 방법일 것 같아요!
Limgabi
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 연관된 이슈 번호
close #34
🌱 주요 변경 사항
📸 스크린샷 (선택)
🗣 리뷰어에게 할 말 (선택)
컨벤션 수정 된 부분이 있어서 우선 현재 작업된 부분 먼저 올리겠습니다
사이드바 코드 로직 및 개선 사항은 추후 곧바로 진행하겠습니다