[#29] - 포트폴리오 피드백 전체 평가 섹션 퍼블리싱 #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 사용자 입력값을 정제하여 보안 강화 - dangerouslySetInnerHTML 사용 시 악성 스크립트 실행 방지
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
🚀 Storybook Deploy : https://67a21b40b49ad2ad0c08c418-zxumebjxtq.chromatic.com/ |
|
데이터 추출 로직 유틸 함수로 분리한거 좋다고 생각합니다!! 혹시 차트 부분을 공통 컴포넌트로 뺀 이유가 있나요?? |
@subsub-e 아직 기능이 구체화되지 않았지만, 그래프는 추후에 다른 기능에서도 재사용할 가능성이 있다고 판단해서 공통 컴포넌트로 분리했습니다! |
minh0518
approved these changes
Feb 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 연관된 이슈 번호
close #29
🌱 주요 변경 사항
dangerouslySetInnerHTML을 사용하였고, 이 과정에서 XSS 방지를 위해dompurify라이브러리를 설치했습니다.📸 스크린샷 (선택)
🗣 리뷰어에게 할 말 (선택)