Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR created that *downgrades* semver v2 compliant nuget package #4805

Closed
AArnott opened this issue Mar 6, 2022 · 4 comments
Closed

PR created that *downgrades* semver v2 compliant nuget package #4805

AArnott opened this issue Mar 6, 2022 · 4 comments
Labels
T: bug 🐞 Something isn't working

Comments

@AArnott
Copy link

AArnott commented Mar 6, 2022

Package ecosystem
NuGet

Manifest location and content prior to update

/.github/dependabot.yml

version: 2
updates:
- package-ecosystem: npm
  directory: /src/nerdbank-streams
  schedule:
    interval: monthly
- package-ecosystem: nuget
  directory: /
  schedule:
    interval: monthly

What you expected to see, versus what you actually saw

Dependabot created dotnet/Nerdbank.Streams#463, which downgrades StyleCop.Analyzers 1.2.0-beta.376 to 1.2.0-beta.66.
Note that this package is using semver v2 rules and that 376 should therefore be seen as better than 66. It seems that Dependabot is treating it as a semver v1 version.

Native package manager behavior

NuGet Package Manager recognizers that .376 is better than .66.

Images of the diff or a link to the PR, issue or logs

dotnet/Nerdbank.Streams#463

-   <PackageReference Include="StyleCop.Analyzers" Version="1.2.0-beta.376" PrivateAssets="all" />
+   <PackageReference Include="StyleCop.Analyzers" Version="1.2.0-beta.66" PrivateAssets="all" />
@AArnott AArnott added the T: bug 🐞 Something isn't working label Mar 6, 2022
@SteveDesmond-ca
Copy link

Additional examples from the past few days:
ecoAPM/SrcSet#29
ecoAPM/StatiqPipelines#10
ecoAPM/StatiqPipelines#11
ecoAPM/ecoAPM.com#29

@SteveDesmond-ca
Copy link

Doing some more digging this morning, it seems dependabot might not support pre-release dependencies, for either just .NET, or maybe many language ecosystems?

#1972 seems like our exact problem here, and #1972 (comment) even points to the offending line of code. Not sure if it's better to close this as duplicate, or keep a more modern issue open, since #1972 is almost 2 years old at this point.

See #1926, #1928, #2250 for the desired functionality.

@AArnott
Copy link
Author

AArnott commented Mar 7, 2022

Thanks for finding the dupes. I'll leave it open for a few days in case it helps draw the desired attention, but ultimately I agree, we should close as a dupe.

@SteveDesmond-ca
Copy link

FWIW, #1972 finally looks to be getting some attention, as it was labelled and assigned last week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: bug 🐞 Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants