-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker bump adds patch version #3933
Comments
This also happened to me today in smrealms/smr#1104
|
This happened today nginx/kubernetes-ingress#1752
|
Is anybody looking into this? It's rather annoying... |
This just happened to me for a github-actions dependency as well: smrealms/smr#1108
|
If you |
My understanding was that dependabot is supposed to retain the specificity of the version, i.e. if you only specify a major version, it would only PR to bump to the next major version (similarly with the minor version). Examples of what I'm expecting:
By increasing the specificity of the version string, dependabot is changing the author's intentions. I feel like this was something that changed recently (in the past few months?), unless I'm mistaken. |
what @hemberger said 🙂 I think the behavior was to match the version until not long ago, and from the other issue it seems like the logic is still there in dependabot-core/docker/lib/dependabot/docker/update_checker.rb Lines 120 to 123 in 7f03508
|
I didn't see it for a while but looks like it's still happening nginx/kubernetes-ingress#2050 |
Just a friendly ping to check if this is being looked at or planned. |
I don't think anyone is currently looking into this, but we're working on getting a better grip of our issue backlog and process around fixing bugs like these. I get that's a frustrating answer that doesn't help you right now, but I hope it will allow us to give a better answer around when we plan to look into this in the future. |
This has essentially the opposite effect of what dependabot wants to achieve: instead of always having an up to date base system because every image build automatically pulls in the latest base image, you end up with an outdated one until dependabot runs again. Running dependant on a monthly schedule, this gets significant. And creates a lot of useless noise. Of course, for projects with very infrequent commits/builds the current behaviour might help, explicitly triggering a rebuild with an update of the base image where it wouldn't have happened otherwise for quite a while. |
Just wanted to add a comment that this is still an issue: smrealms/smr#1377 Actual:
Expected:
Thanks again for providing such a great tool! Hope this can get fixed eventually. :) |
Hi! Just run into this myself, annoying indeed 😅. I will provide a PR shortly, stay tuned! |
#6170 should fix this! |
Package ecosystem
Docker
Updated dependency
Alpine from 3.13 to 3.14.0
What you expected to see, versus what you actually saw
I expected it to be updated to 3.14, not 3.14.0
Images of the diff or a link to the PR, issue or logs
https://github.com/nginxinc/kubernetes-ingress/pull/1672/files
The text was updated successfully, but these errors were encountered: