Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-evaluate the need for the ^vi regex in go_modules #3612

Closed
jeffwidman opened this issue Apr 30, 2021 · 1 comment
Closed

Re-evaluate the need for the ^vi regex in go_modules #3612

jeffwidman opened this issue Apr 30, 2021 · 1 comment
Labels
core 🍏 Relates to the dependabot-core library itself L: go:modules Golang modules

Comments

@jeffwidman
Copy link
Member

See discussion here: #3590 (comment)

It's out of scope for that PR, so opening this ticket so it doesn't get forgotten about.
@jeffwidman jeffwidman mentioned this issue Apr 30, 2021
Closed
@jurre jurre added L: go:modules Golang modules core 🍏 Relates to the dependabot-core library itself labels Nov 30, 2021
@jeffwidman jeffwidman mentioned this issue Nov 30, 2021
Closed
@jeffwidman
Copy link
Member Author

Looking at Jurre's linked comment now that I better understand what's happening internally, I think it's fine to leave as-is. It's confusing, to be sure, but I don't think the inconsistency will be noticed very much so let's just leave as-is unless/until it crops up again.

@jeffwidman jeffwidman closed this as not planned Won't fix, can't repro, duplicate, stale Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core 🍏 Relates to the dependabot-core library itself L: go:modules Golang modules
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jeffwidman @jurre