From 1138e3e2653227c99813f34def3f769831f055a3 Mon Sep 17 00:00:00 2001 From: Philip Harrison Date: Mon, 8 Feb 2021 14:42:42 +0000 Subject: [PATCH] Fix python spec expectations to match new pip error output --- .../update_checker/pip_compile_version_resolver_spec.rb | 8 ++++---- .../update_checker/poetry_version_resolver_spec.rb | 9 ++++----- 2 files changed, 8 insertions(+), 9 deletions(-) diff --git a/python/spec/dependabot/python/update_checker/pip_compile_version_resolver_spec.rb b/python/spec/dependabot/python/update_checker/pip_compile_version_resolver_spec.rb index 918815609b..e80effc033 100644 --- a/python/spec/dependabot/python/update_checker/pip_compile_version_resolver_spec.rb +++ b/python/spec/dependabot/python/update_checker/pip_compile_version_resolver_spec.rb @@ -219,7 +219,7 @@ expect { subject }. to raise_error(Dependabot::DependencyFileNotResolvable) do |error| expect(error.message). - to start_with("Could not find a version that matches boto3") + to include("Could not find a version that matches boto3") end end end @@ -245,7 +245,7 @@ expect { subject }. to raise_error(Dependabot::DependencyFileNotResolvable) do |error| expect(error.message). - to start_with("Could not find a version that matches boto3") + to include("Could not find a version that matches boto3") end end end @@ -273,7 +273,7 @@ expect { subject }. to raise_error(Dependabot::DependencyFileNotResolvable) do |error| expect(error.message). - to start_with("Could not find a version that matches jupyter-server") + to include("Could not find a version that matches jupyter-server") end end end @@ -518,7 +518,7 @@ expect { subject }. to raise_error(Dependabot::DependencyFileNotResolvable) do |error| expect(error.message). - to start_with("Could not find a version that matches boto3") + to include("Could not find a version that matches boto3") end end end diff --git a/python/spec/dependabot/python/update_checker/poetry_version_resolver_spec.rb b/python/spec/dependabot/python/update_checker/poetry_version_resolver_spec.rb index 88c7fd9997..3cb559e7b7 100644 --- a/python/spec/dependabot/python/update_checker/poetry_version_resolver_spec.rb +++ b/python/spec/dependabot/python/update_checker/poetry_version_resolver_spec.rb @@ -230,7 +230,7 @@ expect { subject }. to raise_error(Dependabot::DependencyFileNotResolvable) do |error| expect(error.message). - to include("depends on black (^18) which doesn't match any") + to include("depends on black (>=18,<19) which doesn't match any versions") end end @@ -243,9 +243,7 @@ expect { subject }. to raise_error(Dependabot::DependencyFileNotResolvable) do |error| expect(error.message). - to include("Because pythonprojects depends on croniter "\ - "(0.3.26) which doesn't match any versions, version solving "\ - "failed.") + to include("depends on croniter (==0.3.26) which doesn't match any versions") end end end @@ -294,8 +292,9 @@ it "raises a helpful error" do expect { subject }. to raise_error(Dependabot::DependencyFileNotResolvable) do |error| + puts error.message expect(error.message). - to include("depends on black (^18) which doesn't match any") + to include("depends on black (>=18,<19) which doesn't match any versions") end end end