Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[testing] assertEquals() throws a new Error() instead of a new AssertionError() #555

Closed
todor2810 opened this issue Aug 9, 2019 · 0 comments · Fixed by #560
Closed

[testing] assertEquals() throws a new Error() instead of a new AssertionError() #555

todor2810 opened this issue Aug 9, 2019 · 0 comments · Fixed by #560

Comments

@todor2810
Copy link

todor2810 commented Aug 9, 2019 •
edited
Loading

In deno_std/testing/asserts.ts in the declaration of assertEquals() a new Error() is thrown instead of a new AssertionError().

Possible fix:

Throw a new AssertionError() instead of a new Error() in deno_std/testing/pretty.ts#L83.
@todor2810 todor2810 changed the title [testing] [testing] assertEquals() throw new Error() instead of new AssertionError() Aug 9, 2019
@todor2810 todor2810 changed the title [testing] assertEquals() throw new Error() instead of new AssertionError() [testing] assertEquals() throws a new Error() instead of a new AssertionError() Aug 9, 2019
@bartlomieju bartlomieju mentioned this issue Aug 12, 2019
Merged
@ry ry closed this as completed in #560 Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Use AssertionError in assertEqual
1 participant
@todor2810