Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

suggestion: remove GlobToRegExpOptions.os #4910

Closed
iuioiua opened this issue May 30, 2024 · 2 comments
Closed

suggestion: remove GlobToRegExpOptions.os #4910

iuioiua opened this issue May 30, 2024 · 2 comments

Comments

@iuioiua
Copy link
Contributor

iuioiua commented May 30, 2024 •
edited
Loading

Such a setting doesn't exist in any other API within @std/path. If a user needs to use one of the platform-dependent variations of the function, they can use posix.globToRegExp() for POSIX systems or windows.globToRegExp() for Windows systems, like the rest of the functions within @std/path.
@kt3k
Copy link
Member

kt3k commented May 31, 2024

I'm in favor.

There used to be a plan to make all path APIs taking that option #687 , but we decided to go against that design #3649

It doesn't make sense to me to keep that option now.

@iuioiua iuioiua changed the title suggestion: remove GlobToRegExpOptions.osType suggestion: remove GlobToRegExpOptions.os Jun 2, 2024
@iuioiua
Copy link
Contributor Author

iuioiua commented Jun 4, 2024

Completed in #4928.

@iuioiua iuioiua closed this as completed Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kt3k @iuioiua