Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0.222.0 introduced breaking std/log behavior #4571

Closed
rojvv opened this issue Apr 11, 2024 · 5 comments · Fixed by #4572
Closed

0.222.0 introduced breaking std/log behavior #4571

rojvv opened this issue Apr 11, 2024 · 5 comments · Fixed by #4572
Labels
bug Something isn't working

Comments

@rojvv
Copy link
Contributor

rojvv commented Apr 11, 2024 •
edited
Loading

The following example:

https://deno.land/std@0.222.0/log/mod.ts#example_0

Used to output to the console in 0.221.0, but no more since 0.222.0.
@rojvv rojvv added bug Something isn't working needs triage labels Apr 11, 2024
@kt3k kt3k removed the needs triage label Apr 11, 2024
@rojvv
Copy link
Contributor Author

rojvv commented Apr 11, 2024 •
edited
Loading

This commit introduced the issue: 42df58a (#4436)

@rojvv rojvv mentioned this issue Apr 11, 2024
Merged
@kt3k kt3k mentioned this issue Apr 11, 2024
Merged
@kt3k
Copy link
Member

kt3k commented Apr 11, 2024

@roj1512 Thanks for your quick report!

@rojvv
Copy link
Contributor Author

rojvv commented Apr 11, 2024

And you, for the quick release!

@babiabeo
Copy link
Contributor

https://github.com/denoland/deno_std/blob/42df58a2331f6c028d71a2082809583793ee2442/log/console_handler.ts#L59-L61

I think this change caused the log method to not be called from BaseHandler.handle(), which in turn resulted in no output to the console.

@iuioiua
Copy link
Contributor

iuioiua commented Apr 11, 2024

This was fixed in the latest 0.220.1 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(log): Revert "deprecate(log): deprecate internal utility methods" (#4436) kt3k/deno_std
4 participants
@kt3k @iuioiua @rojvv @babiabeo