Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracking: remove use of TypeScript enums #3782

Closed
9 tasks done
iuioiua opened this issue Nov 8, 2023 · 7 comments
Closed
9 tasks done

tracking: remove use of TypeScript enums #3782

iuioiua opened this issue Nov 8, 2023 · 7 comments
Labels
good first issue Good for newcomers

Comments

@iuioiua
Copy link
Contributor

iuioiua commented Nov 8, 2023

The main reason is that objects align more with native JavaScript than enums. There are also other technical reasons for objects being more desirable over enums. Union types may also work, depending on the scenario.

Enums show up in the following spots:

Note: the enums in front_matter/_format.ts and archive/_common.ts are deliberately omitted as the corresponding implementations will soon be deprecated.

References:

@iuioiua iuioiua added the good first issue Good for newcomers label Nov 8, 2023
@Nkiriobasi
Copy link

Has this been fixed? if not, can I fix it.

@iuioiua
Copy link
Contributor Author

iuioiua commented Nov 10, 2023

Great! Yep, it's still available. Would you like me to assign you?

@Nkiriobasi
Copy link

Yes

@realpha
Copy link
Contributor

realpha commented Nov 22, 2023

hi, is this is still open? (Seems to be without assignee). Could I take a stab at this?

Would it be possible to convert the tasks into individual issues or would you prefer to just reference the tracking issue in the individual prs?

@iuioiua
Copy link
Contributor Author

iuioiua commented Nov 22, 2023

Best that we tackle them in separate PRs and reference this issue.

@realpha
Copy link
Contributor

realpha commented Nov 23, 2023

@iuioiua They are all in progress now.

@iuioiua
Copy link
Contributor Author

iuioiua commented Nov 27, 2023

Thank you for completing these, @realpha. The help is very much appreciated.

@iuioiua iuioiua closed this as completed Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants