Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should sort_by support descending order? #3397

Closed
sant123 opened this issue May 24, 2023 · 2 comments · Fixed by #3419
Closed

Should sort_by support descending order? #3397

sant123 opened this issue May 24, 2023 · 2 comments · Fixed by #3419

Comments

@sant123
Copy link
Contributor

sant123 commented May 24, 2023

Discussed in https://github.com/denoland/deno_std/discussions/3393

Originally posted by sant123 May 22, 2023
Hi, I see that collections/sortBy function orders by ascending. Could it be possible to support descending?

Also not sure if another overloading would be good or creating a new function for this.

Thanks.

I can create a PR with a new function called collections/sortByDesc. Please let me know 🙏🏼
@kt3k
Copy link
Member

kt3k commented May 31, 2023

Maybe let's add { order: "asc" | "desc" } option?

@sant123
Copy link
Contributor Author

sant123 commented Jun 1, 2023

Sure @kt3k. Let me work on that 👀

@sant123 sant123 mentioned this issue Jun 1, 2023
Merged
@kt3k kt3k closed this as completed in #3419 Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(collections/sort_by): descending order can be specified in options
2 participants
@kt3k @sant123