Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework ConsoleHandler to use native console methods #2645

Open
nesk opened this issue Sep 12, 2022 · 0 comments
Open

Rework ConsoleHandler to use native console methods #2645

nesk opened this issue Sep 12, 2022 · 0 comments
Labels

Comments

@nesk
Copy link

nesk commented Sep 12, 2022

Is your feature request related to a problem? Please describe.

When using the log module with Deno Deploy, the output is not "native" in the dashboard:

Screenshot 2022-09-12 at 21-21-33 actions - Project - Deploy Redacted

Describe the solution you'd like

Deno Deploy provides a clean UI for logs outputed with the debug, info, warn, error methods, what about using those by default in ConsoleHandler?

Screenshot 2022-09-12 at 21-22-13 actions - Project - Deploy Redacted

Describe alternatives you've considered

The ConsoleHandler can be useful but in a terminal, what about renaming it TerminalHandler and creating a new ConsoleHandler?

  • TerminalHandler: always outputs with console.log and formats data by itself, like the current ConsoleHandler.
  • ConsoleHandler: outputs with the appropriate console.* methods, lets Deno Deploy handle the formatting.

The only drawback I can see is the missing critical method in the native console API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants