Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: change example for readableStreamFromReader and writableStreamFromWriter #2505

Closed
erfanium opened this issue Aug 8, 2022 · 4 comments

Comments

@erfanium
Copy link
Contributor

erfanium commented Aug 8, 2022

Currently doc examples suggests using readableStreamFromReader and writableStreamFromWriter to get a readableStream or writeableStream from a FsFile which is not required anymore after denoland/deno#13615

bad docs:

@erfanium erfanium changed the title stream: deprecate readableStreamFromReader and writableStreamFromWriter stream: remove/deprecate readableStreamFromReader and writableStreamFromWriter Aug 8, 2022
@crowlKats
Copy link
Member

Things can still just be a Deno.Reader or Deno.Writer, as one can just create an object with the required functions, so having readableStreamFromReader & writableStreamFromWriter still makes sense.

@erfanium
Copy link
Contributor Author

erfanium commented Aug 8, 2022

@crowlKats Yeah, I'm now changing this issue to improve docs, because doc suggests readableStreamFromReader to read from FsFile

@erfanium erfanium changed the title stream: remove/deprecate readableStreamFromReader and writableStreamFromWriter docs: change example for readableStreamFromReader and writableStreamFromWriter Aug 8, 2022
@lino-levan
Copy link
Contributor

@kt3k with this being deprecated, we can probably close this issue.

@kt3k
Copy link
Member

kt3k commented Sep 25, 2023

Thanks for the ping.

Closing as these APIs have been deprecated in #3640

@kt3k kt3k closed this as completed Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants