Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file_server: Chrome DevTools Workspaces stopped working #2251

Open
fonsp opened this issue May 19, 2022 · 0 comments
Open

file_server: Chrome DevTools Workspaces stopped working #2251

fonsp opened this issue May 19, 2022 · 0 comments
Labels
bug Something isn't working needs investigation Needs further investigation

Comments

@fonsp
Copy link
Contributor

fonsp commented May 19, 2022

Describe the bug

The Chrome DevTools Workspaces feature, which allows editing local source files directly from the inspector (💕), stopped working in combination with a local file_server. I bisected the problem, and it appeared between v0.102.0 and v0.103.0, which leads to #1028.

Indeed, this SO answer suggests that the Workspaces feature looks at the date headers in the response, and those were added in #1028.

Steps to Reproduce

Serve a basic static site with file_server, visit the site in chrome and follow these steps to set up Workspaces.

Environment

Here is a screenshot of the headers of a (recently edited) file, next to my local time, which is GMT+2. It looks correct.

  • OS: MacOS 12
  • deno version: 1.19.2
  • std version: Working on v0.87.0 until v0.102.0, broken on v0.103.0 until v0.140.0.
@fonsp fonsp added bug Something isn't working needs triage labels May 19, 2022
@kt3k kt3k added needs investigation Needs further investigation and removed needs triage labels May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs investigation Needs further investigation
Projects
None yet
Development

No branches or pull requests

2 participants