Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

suggestion: deprecate Deno.kill() #25405

Closed
iuioiua opened this issue Sep 3, 2024 · 1 comment
Closed

suggestion: deprecate Deno.kill() #25405

iuioiua opened this issue Sep 3, 2024 · 1 comment
Labels
public API related to "Deno" namespace in JS suggestion suggestions for new features (yet to be agreed)

Comments

@iuioiua
Copy link
Contributor

iuioiua commented Sep 3, 2024 •
edited
Loading

IIUC, it has no other use case outside spawned processes. After Deno 2, one can just use Deno.ChildProcess.prototype.kill. At this point, the deprecation can happen at Deno 2, and the removal sometime after.
@iuioiua iuioiua added public API related to "Deno" namespace in JS suggestion suggestions for new features (yet to be agreed) labels Sep 3, 2024
@iuioiua iuioiua mentioned this issue Sep 3, 2024
Merged
@lucacasonato
Copy link
Member

Deno.kill is useful to kill process groups by passing in a negative process id. This is not possible with ChildProcess.prototype.kill.

@iuioiua iuioiua closed this as not planned Won't fix, can't repro, duplicate, stale Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
public API related to "Deno" namespace in JS suggestion suggestions for new features (yet to be agreed)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lucacasonato @iuioiua