using keyword generate various errors

[JOTSR]

Version: Deno 1.40.4

Summary

Declarations of an instance of a local Disposable class generate the following errors:

• LSP is broken (code completions does not work anymore)
• Runtime throws error when calling Symbol.dispose/Symbol.asyncDispose

Calling Symbol.dispose result in error if there is more than one scope with using or when there is using in global scope with local class.

Examples

With Symbol.dispose

export class Disposable {
    [Symbol.dispose]() {
        console.log('dispose')
    }

}

using _f = await Deno.open('./demo.txt')

console.log('ok')

$ deno run --allow-read=. ./src/example.ts
ok

With Symbol.dispose and global using

export class Disposable {
    [Symbol.dispose]() {
        console.log('dispose')
    }

}

using _disposable = new Disposable()

console.log('ok')

$ deno run --allow-read=. ./src/example.ts
error: Uncaught (in promise) TypeError: Property [Symbol.dispose] is not a function.
Warning Couldn't format source line: Line 52 is out of bounds (source may have changed at runtime)
    at _using (file:///.../src/example.ts:52:11)
    at file:///.../src/example.ts:9:1

With Symbol.dispose and scoped using

export class Disposable {
    [Symbol.dispose]() {
        console.log('dispose')
    }

}

{
    using _disposable = new Disposable()
}

console.log('ok')

$ deno run --allow-read=. ./src/example.ts
dispose
ok

With Symbol.dispose scoped using and Deno using

export class Disposable {
    [Symbol.dispose]() {
        console.log('dispose')
    }

}

using _f = await Deno.open('./demo.txt')

{
    using _disposable = new Disposable()
}

console.log('ok')

$ deno run --allow-read=. ./src/example.ts
error: Uncaught (in promise) TypeError: Property [Symbol.dispose] is not a function.
Warning Couldn't format source line: Line 52 is out of bounds (source may have changed at runtime)
    at _using (file:///.../src/example.ts:52:11)
    at file:///.../src/example.ts:11:5
    at eventLoopTick (ext:core/01_core.js:65:7)

With Symbol.dispose scoped using and scoped Deno using

export class Disposable {
    [Symbol.dispose]() {
        console.log('dispose')
    }

}

{
    using _f = await Deno.open('./demo.txt')
    using _disposable = new Disposable()
}

console.log('ok')

$ deno run --allow-read=. ./src/example.ts
dispose
ok

With Symbol.AsyncDispose scoped using and scoped Deno using

export class Disposable {
    [Symbol.asyncDispose]() {
        console.log('dispose')
    }

}

{
    using _f = await Deno.open('./demo.txt')
    await using _asyncDisposable = new AsyncDisposable()
}

console.log('ok')

$ deno run --allow-read=. ./src/example.ts
dispose
ok

With Symbol.AsyncDispose scoped using and Deno using

export class Disposable {
    [Symbol.asyncDispose]() {
        console.log('dispose')
    }

}

using _f = await Deno.open('./demo.txt')

{
    await using _asyncDisposable = new AsyncDisposable()
}

console.log('ok')

$ deno run --allow-read=. ./src/example.ts
dispose
ok

With Symbol.AsyncDispose scoped using and scoped Deno using

export class Disposable {
    async [Symbol.asyncDispose]() {
        console.log('dispose')
    }

}

{
    using _f = await Deno.open('./demo.txt')
    await using _asyncDisposable = new AsyncDisposable()
}

console.log('ok')

$ deno run --allow-read=. ./src/example.ts
dispose
ok

With Symbol.AsyncDispose scoped using and Deno using

export class Disposable {
    async [Symbol.asyncDispose]() {
        console.log('dispose')
    }

}

using _f = await Deno.open('./demo.txt')

{
    await using _asyncDisposable = new AsyncDisposable()
}

console.log('ok')

$ deno run --allow-read=. ./src/example.ts
error: Uncaught (in promise) TypeError: Property [Symbol.dispose] is not a function.
Warning Couldn't format source line: Line 52 is out of bounds (source may have changed at runtime)
    at _using (file:///.../src/example.ts:52:11)
    at file:///.../src/example.ts:11:5
    at eventLoopTick (ext:core/01_core.js:65:7)

[dsherret]

This is a regression. I opened swc-project/swc#8629

[bombillazo]

Hey, I tried using using as well recently but we get a TypeError: Property [Symbol.dispose] is not a function. error, we are only defining asyncDispose since it is a connection closing function.

[BlowaterNostr]

Same problem here. It fails in Linux (GitHub Action)

deno 1.44.0 (release, x86_64-unknown-linux-gnu)
v8 12.6.228.3
typescript 5.4.5

using https://github.com/denoland/setup-deno

[lucacasonato]

All of these examples are working for me in Deno 1.44.1.

@BlowaterNostr please share what issue you are running into if it is not fixed.