Stabilize Deno.upgradeHttp?

[imcotton]

It was introduced on 1.20.1 / 2022.03.16 ¹, any stories left from moving it into stable?

Thanks.

Footnotes

1. https://github.com/denoland/deno/blob/ae327d0a83be3ad56d42cad7db0b15ae8e853f06/Releases.md?plain=1#L2197 ↩

[crowlKats]

Since we have Deno.serve, whats the usecase you have for Deno.upgradeHttp?

[imcotton]

My use case is for standard CONNECT proxy server along with Deno.listen / Deno.listenTls, learnt from #11744.

Haven't tried Deno.serve for the same task yet, not sure it's sufficient for this job tho.

[mmastrac]

I looked into this briefly and I believe the upgradeHttp and upgradeHttpRaw API is not currently suitable for CONNECT. These are designed for use with websockets and node.js emulation as they assume an HTTP transaction is completed by whoever writes to the returned connection.

I think it is probably more suitable if we develop a Deno.upgradeConnect method that works for HTTP/1 and HTTP/2.

[mmastrac]

This API was never really designed for use with anything other than node.js compatibility, so we're likely just going to make it internal only.

Closing this in favour of a dedicated CONNECT API RFC -- please feel free to comment on it: #21870