From 2d8f5e9c79da70642a1942e2c3f953df9aa9d18c Mon Sep 17 00:00:00 2001 From: KITAGAWA Yasutaka Date: Sun, 23 Feb 2025 07:51:26 +0900 Subject: [PATCH 1/2] Fix CI lint errors --- src/common/shell.rs | 1 + src/common/terminal.rs | 2 +- src/parser.rs | 5 ++--- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/common/shell.rs b/src/common/shell.rs index 13f5bbf7..87e34eb2 100644 --- a/src/common/shell.rs +++ b/src/common/shell.rs @@ -12,6 +12,7 @@ pub enum Shell { Fish, Elvish, Nushell, + #[allow(clippy::enum_variant_names)] PowerShell, } diff --git a/src/common/terminal.rs b/src/common/terminal.rs index e20432bc..b88bf41e 100644 --- a/src/common/terminal.rs +++ b/src/common/terminal.rs @@ -50,7 +50,7 @@ pub fn parse_ansi(ansi: &str) -> Option { } #[derive(Debug, Clone)] -pub struct Color(pub style::Color); +pub struct Color(#[allow(unused)] pub style::Color); // suppress warning: field `0` is never read. impl FromStr for Color { type Err = &'static str; diff --git a/src/parser.rs b/src/parser.rs index bcdda8f6..e1d4d2bd 100644 --- a/src/parser.rs +++ b/src/parser.rs @@ -254,9 +254,8 @@ impl<'a> Parser<'a> { } // duplicate - if !item.tags.is_empty() { - item.comment.is_empty(); - } + // if !item.tags.is_empty() && !item.comment.is_empty() {} + // blank if line.is_empty() { if !item.snippet.is_empty() { From 0e8e5c5af7c1dc53c6c4e0b761cdbc5e4658c9df Mon Sep 17 00:00:00 2001 From: KITAGAWA Yasutaka Date: Tue, 25 Feb 2025 13:04:16 +0900 Subject: [PATCH 2/2] Run ci on pull requests --- .github/workflows/ci.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 9e2f2618..5bc35664 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -4,7 +4,10 @@ # for simplicity we are compiling and testing everything on the Ubuntu environment only. # For multi-OS testing see the `cross.yml` workflow. -on: [push] +on: + push: + pull_request: + branches: [master] name: CI