Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

Local builds are broken for mac #286

Closed
ralphtheninja opened this issue Apr 26, 2019 · 9 comments
Closed

Local builds are broken for mac #286

ralphtheninja opened this issue Apr 26, 2019 · 9 comments

Comments

@ralphtheninja
Copy link
Member

ralphtheninja commented Apr 26, 2019

ldfalgs should most likely be ldflags and some other rpath stuff needs to be tested.

@ralphtheninja
Copy link
Member Author

@flub Feel like checking this out tomorrow?

@flub
Copy link
Member

flub commented Apr 27, 2019

#288 to fix

@ralphtheninja
Copy link
Member Author

Builds are compiling and linking now but still some issues. SMTP is not working for me on linux and @nicodh have the same issues on mac.

@ralphtheninja
Copy link
Member Author

@flub I'm guessing that if deltachat.node is linking with libdeltachat.so now, this means we're using system wide installed dependencies of libdeltachat.so. For some reason this doesn't work on my machine. If I build deltachat.node and use that in desktop I get the following error:

'Could not connect to IMAP-server imap.deltachat.net:993 using SSL. (Error #43)'

I get the exact same error when trying deltachat-core-rust (maybe not surprising).

@flub
Copy link
Member

flub commented Apr 28, 2019 via email

@Jikstra
Copy link
Collaborator

Jikstra commented Apr 28, 2019

I think we need to still link against the System Frameworks for security...
Adding those lines fixed it some months ago:

        [ "OS == 'mac'", {
          "libraries": [
            "../deltachat-core/builddir/src/libdeltachat.a",
            "/usr/local/Cellar/libetpan/1.9.2_1/lib/libetpan.a",
            "/usr/local/lib/rpgp/libpgp_ffi.a",
            "-framework CoreFoundation",
            "-framework CoreServices",
            "-framework Security",
            "-lsasl2",
            "-lssl",
            "-lsqlite3",
            "-lpthread"
]

@flub
Copy link
Member

flub commented Apr 28, 2019

@ralphtheninja your issue on Debian/Ubuntu/Linux is probably https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=927709 aka dinhvh/libetpan#330 which you can fix by installing libetpan from source from the master branch. I had the same issue locally and that fixed it. If not it should possibly be a separate issue to track?

@flub
Copy link
Member

flub commented Apr 28, 2019

@nicodh could you try enabling rpgp in scripts/rebuild-core.js and see if that changes anything here?

@Jikstra
Copy link
Collaborator

Jikstra commented May 14, 2019

As builds are green again on mac, i think this should get closed? @ralphtheninja @nicodh

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants