From 8861eb5e7b9bd0b81575e03ed24b2fc7aaaeb81d Mon Sep 17 00:00:00 2001 From: Yijie Shen Date: Mon, 17 Jul 2023 09:08:17 -0700 Subject: [PATCH 1/4] make delta_datafusion::find_files pub --- rust/src/delta_datafusion.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rust/src/delta_datafusion.rs b/rust/src/delta_datafusion.rs index 3147a88938..252457a8df 100644 --- a/rust/src/delta_datafusion.rs +++ b/rust/src/delta_datafusion.rs @@ -1289,7 +1289,7 @@ pub(crate) async fn scan_memory_table( join_batches_with_add_actions(batches, map) } -pub(crate) async fn find_files<'a>( +pub async fn find_files<'a>( snapshot: &DeltaTableState, object_store: ObjectStoreRef, schema: Arc, From b252c908e28318c00cd35038aca2196f63b311e9 Mon Sep 17 00:00:00 2001 From: Yijie Shen Date: Mon, 17 Jul 2023 11:24:05 -0700 Subject: [PATCH 2/4] pub FindFiles --- rust/src/delta_datafusion.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rust/src/delta_datafusion.rs b/rust/src/delta_datafusion.rs index 252457a8df..c4ac79406e 100644 --- a/rust/src/delta_datafusion.rs +++ b/rust/src/delta_datafusion.rs @@ -1085,7 +1085,7 @@ impl TreeNodeVisitor for FindFilesExprProperties { } } -pub(crate) struct FindFiles { +pub struct FindFiles { pub candidates: Vec, /// Was a physical read to the datastore required to determine the candidates pub partition_scan: bool, From 19c906bc556bec7cf00c4c825f284a1cd0242ee2 Mon Sep 17 00:00:00 2001 From: Yijie Shen Date: Tue, 25 Jul 2023 10:57:05 -0700 Subject: [PATCH 3/4] docs --- rust/src/delta_datafusion.rs | 3 +++ 1 file changed, 3 insertions(+) diff --git a/rust/src/delta_datafusion.rs b/rust/src/delta_datafusion.rs index c4ac79406e..6056dfada3 100644 --- a/rust/src/delta_datafusion.rs +++ b/rust/src/delta_datafusion.rs @@ -1085,7 +1085,9 @@ impl TreeNodeVisitor for FindFilesExprProperties { } } +/// Representing the result of the `find_files` function. pub struct FindFiles { + /// A list of `Add` objects that match the given predicate pub candidates: Vec, /// Was a physical read to the datastore required to determine the candidates pub partition_scan: bool, @@ -1289,6 +1291,7 @@ pub(crate) async fn scan_memory_table( join_batches_with_add_actions(batches, map) } +/// Finds files in a snapshot that match the provided predicate. pub async fn find_files<'a>( snapshot: &DeltaTableState, object_store: ObjectStoreRef, From f0418d8cc27df3cd10a3eab67752026b97376b91 Mon Sep 17 00:00:00 2001 From: Will Jones Date: Wed, 26 Jul 2023 21:21:43 -0700 Subject: [PATCH 4/4] Update rust/src/delta_datafusion.rs --- rust/src/delta_datafusion.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rust/src/delta_datafusion.rs b/rust/src/delta_datafusion.rs index 6056dfada3..6c8f4a13bc 100644 --- a/rust/src/delta_datafusion.rs +++ b/rust/src/delta_datafusion.rs @@ -1085,7 +1085,7 @@ impl TreeNodeVisitor for FindFilesExprProperties { } } -/// Representing the result of the `find_files` function. +/// Representing the result of the [find_files] function. pub struct FindFiles { /// A list of `Add` objects that match the given predicate pub candidates: Vec,