Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to cargo update using git tag or rev on Rust 1.70 #1580

Closed
cmackenzie1 opened this issue Aug 1, 2023 · 6 comments
Closed

Unable to cargo update using git tag or rev on Rust 1.70 #1580

cmackenzie1 opened this issue Aug 1, 2023 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@cmackenzie1
Copy link
Contributor

Environment

Delta-rs version: 0.14

Binding: rust

Environment:

  • Cloud provider:
  • OS:
  • Other:

Bug

What happened:

cargo update fails to find deltalake when using git to specify cargo dependency.

What you expected to happen:

cargo update to succeed

How to reproduce it:

# Cargo.toml
[dependencies]
deltalake = { git = "https://github.com/delta-io/delta-rs.git", tag = "rust-v0.14.0", features = [
    "s3",
    "parquet",
    "arrow",
    "datafusion",
] }
$ rustup install 1.70.0
$ cargo +1.70.0 update
    Updating crates.io index
    Updating git repository `https://github.com/delta-io/delta-rs.git`
error: no matching package named `deltalake` found
location searched: https://github.com/delta-io/delta-rs.git?tag=rust-v0.14.0
$ rustup install 1.71.0
$ cargo +1.71.0 update
    Updating crates.io index
    Updating git repository `https://github.com/delta-io/delta-rs.git`

More details:

Using crates.io format deltalake = { version = "0.14.0" } works fine.

Could potentially be related to #1572 ? There were some cargo workspace related changes in cargo, https://github.com/rust-lang/cargo/blob/master/CHANGELOG.md#cargo-171-2023-07-13

@cmackenzie1 cmackenzie1 added the bug Something isn't working label Aug 1, 2023
@cmackenzie1
Copy link
Contributor Author

Fails for 1.69.0 as well.

$ rustup install 1.69.0
$ cargo +1.69.0 update
    Updating crates.io index
remote: Enumerating objects: 160156, done.
remote: Counting objects: 100% (19115/19115), done.
remote: Compressing objects: 100% (398/398), done.
remote: Total 160156 (delta 18721), reused 19075 (delta 18694), pack-reused 141041
Receiving objects: 100% (160156/160156), 104.91 MiB | 4.62 MiB/s, done.
Resolving deltas: 100% (116010/116010), completed with 2288 local objects.
From https://github.com/rust-lang/crates.io-index
 + c840c3f7c3...59bdc2e853            -> origin/HEAD  (forced update)
    Updating git repository `https://github.com/delta-io/delta-rs.git`
error: no matching package named `deltalake` found
location searched: https://github.com/delta-io/delta-rs.git?tag=rust-v0.14.0

@cmackenzie1
Copy link
Contributor Author

Works OK for rust 1.70 and git tag rust-v0.13.0. Looks more and more likely its due to the workspace changes :(

@rtyler
Copy link
Member

rtyler commented Aug 1, 2023

Does this fail in the same way when you use a branch rather than the tag reference?

@cmackenzie1
Copy link
Contributor Author

Yeah, I tried pointing it at my fork but got the same result. It seems any git style pointer fails rust<=1.70 for v0.14

@rtyler
Copy link
Member

rtyler commented Aug 6, 2023

According to one of the fine folks over the in the cargo project, this is more likely to be the addition of the line-tables-only option, which I'm hopeful we can make apply only on newer Cargo versions

@rtyler
Copy link
Member

rtyler commented Sep 15, 2023

Going to close t his out, it's kinda annoying but we should encourage people to use newer cargoes since the upstream issue (in cargo somewhere) is not likely going to be fixed soon

@rtyler rtyler closed this as completed Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants