-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NuGET deltalake.net.0.2.0 is missing libdelta_kernel_ffi #106
Comments
@dmunch We weren't setting the |
Awesome, thanks a lot for the quick fix! |
Unfortunately publishing the NuGet is now failing since the package size (305mb) exceeds the package size limit of 250mb. NuGet/NuGetGallery#9473 |
@mdrakiburrahman We have this comment in the code about release builds of delta_kernel. I have tried testing locally with a release build and it seems to work. Are you still experiencing this issue? This is working on a branch with the latest delta-rs. |
The CI test was failing when I wrote that. If the tests are passing now on the Release build*, then it's probably some Rust thing that I do not understand, and no concerns on my end if we want to start using the Release build |
@mightyshazam - so basically, if the branch above passes the new read test I added with the Kernel-based read on release build, we're good to go. If not, then let me know, if this Nuget size is caused due to the debug build, I need to sort that out since I introduced it. |
The nuget size is probably due to the debug build. It adds 50MB on osx-arm, so it is safe to assume the other targets are responsible for at least 50 more, putting us over the limit. I have a PR to test the build #108 with the update to delta rs. |
Sounds good, please let me know if you need me for anything. |
Thanks again for the quick turnaround: NuGet with version 0.22.3 now works fine on my local machine |
I was trying to use the NuGet by adopting the example and instead of referencing the
csproj
and native binaries directly, I used the NuGet package.I.e. my
.csproj
looks like thisProject compiles fine, however when running, I get
So I've downloaded the package manually and unzipped it, verifying its contents, and indeed, that file is missing.
(python-env) ➜ deltalake.net.0.2.0 git:(main) ✗ tree . ├── DeltaLake.Net.nuspec ├── README.md ├── [Content_Types].xml ├── _rels ├── lib │ ├── net6.0 │ │ ├── DeltaLake.dll │ │ └── DeltaLake.xml │ └── net8.0 │ ├── DeltaLake.dll │ └── DeltaLake.xml ├── package │ └── services │ └── metadata │ └── core-properties │ └── 30cc255eb0124b6a8ddc995f282b59f8.psmdcp └── runtimes ├── linux-arm64 │ └── native │ └── libdelta_rs_bridge.so ├── linux-x64 │ └── native │ └── libdelta_rs_bridge.so ├── osx-arm64 │ └── native │ └── libdelta_rs_bridge.dylib ├── osx-x64 │ └── native │ └── libdelta_rs_bridge.dylib └── win-x64 └── native └── delta_rs_bridge.dll 20 directories, 13 files
Having had a look at DeltaLake.csproj, it seems like its currently referencing the
debug
binary of the missing file, even in release mode (due to reasons well explained in the file). So maybe it's a case of this file not being explicitly built in the Github Action package.yml ?The text was updated successfully, but these errors were encountered: