fix: add zarf var for k3d_extra_args #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikevanhemert
previously approved these changes
Dec 19, 2023
mjnagel
previously approved these changes
Dec 19, 2023
jeff-mccoy
reviewed
Dec 19, 2023
|
@jeff-mccoy that's a good point, it would currently break RWX without an extra arg to volume mount a common directory to the nodes for RWX storage 🤔 |
|
Fair, but that's only if you need RWX. Alternatively, the README example could be updated to set the debug k3s arg used in the pepr k3d setup npm script. |
jeff-mccoy
reviewed
Jan 10, 2024
mjnagel
reviewed
Jan 17, 2024
zachariahmiller
dismissed stale reviews from mjnagel and mikevanhemert
via
cd0713d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add zarf var to provide additional k3d config arguments
Related Issue
Fixes #
Relates to #
Type of change
Checklist before merging