-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: add extra port support #103
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed and approved licensing and asked a single question. I will definitely defer to the UDS Core folks for review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a huge fan of adding this complexity, especially untested here, but I do see the testing need if trying to enable something like GitLab + SSH.
We could add some light testing if we wanted to have a simple nginx app with a loadbalancer in front of it responding over different ports |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approving for codeowner pieces per @mjnagel
Description
This adds support for adding additional ports to
uds-k3d
for testing with uds packages that may require additional ports to be exposed.Related Issue
Fixes #N/A
Type of change
Checklist before merging