Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: add extra port support #103

Merged
merged 3 commits into from
Sep 16, 2024
Merged

feat!: add extra port support #103

merged 3 commits into from
Sep 16, 2024

Conversation

Racer159
Copy link
Contributor

@Racer159 Racer159 commented Sep 16, 2024

Description

This adds support for adding additional ports to uds-k3d for testing with uds packages that may require additional ports to be exposed.

⚠️ BREAKING CHANGE This PR removes the passthrough gateway rules for the older login.uds.dev and keycloak.uds.dev entries.

Related Issue

Fixes #N/A

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@Racer159 Racer159 requested a review from a team as a code owner September 16, 2024 17:39
Copy link

@daveworth daveworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed and approved licensing and asked a single question. I will definitely defer to the UDS Core folks for review

docs/DNS.md Show resolved Hide resolved
Copy link
Contributor

@mjnagel mjnagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a huge fan of adding this complexity, especially untested here, but I do see the testing need if trying to enable something like GitLab + SSH.

chart/templates/nginx.yaml Show resolved Hide resolved
chart/templates/nginx.yaml Show resolved Hide resolved
@Racer159
Copy link
Contributor Author

Not a huge fan of adding this complexity, especially untested here, but I do see the testing need if trying to enable something like GitLab + SSH.

We could add some light testing if we wanted to have a simple nginx app with a loadbalancer in front of it responding over different ports

@Racer159 Racer159 changed the title feat: add extra port support feat!: add extra port support Sep 16, 2024
@mjnagel mjnagel enabled auto-merge (squash) September 16, 2024 21:39
Copy link

@daveworth daveworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving for codeowner pieces per @mjnagel

@mjnagel mjnagel merged commit 9299bc5 into main Sep 16, 2024
0 of 3 checks passed
@mjnagel mjnagel deleted the add-extra-port-support branch September 16, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants