Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identify tool or process for document schema validation #10

Closed
brandtkeller opened this issue Aug 19, 2022 · 11 comments
Closed

Identify tool or process for document schema validation #10

brandtkeller opened this issue Aug 19, 2022 · 11 comments
Assignees
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed

Comments

@brandtkeller
Copy link
Member

Knowing early what is or is-not valid OSCAL schema will be important for extending the OSCAL component files.

Provide documentation or automation for validating OSCAL schema.

@brandtkeller brandtkeller added documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed labels Aug 19, 2022
@brandtkeller brandtkeller transferred this issue from another repository Sep 2, 2022
@brandtkeller
Copy link
Member Author

Moving to post-POC for DD objectives

@brandtkeller brandtkeller added the post-POC Functionality for post-proof-of-concept label Sep 12, 2022
@brandtkeller
Copy link
Member Author

Currently no validation around the oscal files being ingested. Implementation might look like a separate command that is utilized to help document developers target problems (line/object etc) and resolve them.

@brandtkeller
Copy link
Member Author

https://github.com/GoComply/oscalkit does provide this validation logic. The validation looks to occur by supplying a schema to validate a given document against.

Investigation needs to happen around how we might handle multiple versions of documents being used with a single version of the tool and what schemas we have within the compiled binary.

@brandtkeller brandtkeller removed the post-POC Functionality for post-proof-of-concept label Oct 29, 2022
@brandtkeller
Copy link
Member Author

Clarifying context around this issue should be separated into two categories:

  • Lula needs to test (Likely E2E) that any expectations for input AND reports generated for output are valid to the OSCAL schema
  • How Lula will respond to invalid oscal. Error handling should be first priority - helper commands secondary as there are existing schema validation tools available.

@brandtkeller brandtkeller moved this to 🔖 Ready in Lula and Friends Sep 12, 2023
@CloudBeard CloudBeard self-assigned this Sep 26, 2023
@CloudBeard
Copy link
Collaborator

CloudBeard commented Sep 29, 2023

Tested OSCAL-CLI github action. Seems to be solid.

Pros:
OSCAL-CLI is maintained by NIST.
OSCAL-CLI-Action is maintained by OSCAL Club.
Can be used to validate and convert each part of OSCAL

Cons:
TBD

@xee5ch
Copy link

xee5ch commented Sep 30, 2023

The GitHub Action, oscal-cli-action, is maintained by the OSCAL Club community not NIST, but the core CLI is from NIST though. Let us know how we can help (I am the maintainer of that action).

@CloudBeard
Copy link
Collaborator

@xee5ch thanks for the call out, I updated my Pros/Cons to reflect that! Still in the early phases of testing but everything seems to be straight forward. Thanks for the hard work on it!

@xee5ch
Copy link

xee5ch commented Sep 30, 2023

No worries, thanks for testing it, we have not got much feedback on it yet. You did remind me to release the updated copy defaulting to v1.0.2 of the CLI out of the oven, so hopefully it keeps delivering value. :-)

@CloudBeard CloudBeard moved this from 🔖 Ready to 🏗 In progress in Lula and Friends Oct 3, 2023
@CloudBeard
Copy link
Collaborator

Found issue with OSCAL-CLI validation command not being able to find json schema file: usnistgov/oscal-cli#200

Fix should be in next release.

@mike-winberry
Copy link
Contributor

@brandtkeller brandtkeller self-assigned this Dec 1, 2023
@brandtkeller
Copy link
Member Author

document schema validation implemented in #136

@brandtkeller brandtkeller moved this from 🏗 In progress to 👀 In review in Lula and Friends Dec 1, 2023
@brandtkeller brandtkeller moved this from 👀 In review to ✅ Done in Lula and Friends Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed
Projects
Archived in project
Development

No branches or pull requests

4 participants