Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance of RESTful API #324

Open
kihanc opened this issue Nov 23, 2023 · 9 comments
Open

Performance of RESTful API #324

kihanc opened this issue Nov 23, 2023 · 9 comments
Assignees

Comments

@kihanc
Copy link

kihanc commented Nov 23, 2023

I have measured the performance of Mistral 7B w/ and w/o Restful API, and got 7.1 reqs/s and 0.48 reqs/s individually.
(avg. input/output tokens: 232/208, A100 80GB)

@mrwyattii
Copy link
Contributor

Hi @kihanc we are aware of performance issues related to the restful API and will be providing an update on this feature soon. Thanks

@mrwyattii
Copy link
Contributor

@kihanc please try with the latest main branch. I have made improvements that allow us to match performance the RESTful API to our Python API (see #328).

@BaiMoHan
Copy link

@kihanc please try with the latest main branch. I have made improvements that allow us to match performance the RESTful API to our Python API (see #328).

Hey, how can I make Restful start and listen on 0.0.0.0 instead of localhost? I often encounter situations where I deploy my application on a remote machine but cannot test it using external API tools like Postman because it only listens on localhost.

@PawanOsman
Copy link
Contributor

@kihanc please try with the latest main branch. I have made improvements that allow us to match performance the RESTful API to our Python API (see #328).

Hey, how can I make Restful start and listen on 0.0.0.0 instead of localhost? I often encounter situations where I deploy my application on a remote machine but cannot test it using external API tools like Postman because it only listens on localhost.

I think it's using localhost by default and there is no option to set it, you can modify this file locally until they add an option to set the hostname

@BaiMoHan
Copy link

@kihanc please try with the latest main branch. I have made improvements that allow us to match performance the RESTful API to our Python API (see #328).

Hey, how can I make Restful start and listen on 0.0.0.0 instead of localhost? I often encounter situations where I deploy my application on a remote machine but cannot test it using external API tools like Postman because it only listens on localhost.

I think it's using localhost by default and there is no option to set it, you can modify this file locally until they add an option to set the hostname

Thank you!

@kihanc
Copy link
Author

kihanc commented Dec 19, 2023

@mrwyattii Thanks for the quick update! Your test code works perfectly on our end. But, if we hit more than 100 requests at once, things get wonky and connections are reset. It would be awesome if you could add support for concurrent connections on your API server.

@mrwyattii
Copy link
Contributor

mrwyattii commented Dec 19, 2023

@kihanc if you increase the number of restful_processes (which defaults to 32) does that help? Perhaps try 64?

mii.serve(model_name, restful_processes=64, enable_restful_api=True)

@kihanc
Copy link
Author

kihanc commented Dec 20, 2023

@mrwyattii I already tried that before but that was not helpful.

@IKACE
Copy link

IKACE commented Apr 17, 2024

Do we have any updates on this issue? I am also observing "Connection reset" failures when request rate is high

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants